-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use posix socket APIs #4206
Open
maxz-lab
wants to merge
6
commits into
25.lts.1+
Choose a base branch
from
cherry-pick-25.lts.1+-3601
base: 25.lts.1+
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Use posix socket APIs #4206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced API SbPosixSocketWaiterAdd, SbPosixSocketWaiterRemove and callback SbPosixSocketWaiterCallback. Tests added are SbPosixSocketWaiterAdd SbPosixSocketWaiterRemove SbPosixSocketWaiterWait SbPosixSocketWaiterWaitTimed libevent and win32 SocketWaiter module supports both integer based socket and SbSocket socket in SB16. This is PR3601 on main branch. b/302741384
Replace net/tcp&udp_starboard with net/tcp&udp_posix. This is PR3904 on main branch. b/302741384
jellefoks
reviewed
Oct 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@y4vor These would have to go into an extension, right?
maxz-lab
force-pushed
the
cherry-pick-25.lts.1+-3601
branch
4 times, most recently
from
October 7, 2024 02:58
575aa30
to
de60f97
Compare
maxz-lab
force-pushed
the
cherry-pick-25.lts.1+-3601
branch
2 times, most recently
from
October 15, 2024 04:42
7cc1f98
to
c674799
Compare
Detect "_MSC_VER" on win32/xbox. b/302741384
maxz-lab
force-pushed
the
cherry-pick-25.lts.1+-3601
branch
from
October 16, 2024 15:51
c674799
to
6c75f2b
Compare
The reverts the test change made in PR3904. b/302741384
Change (PR3904) replaced recvmsg() with recvfrom unnecessarily. This change to restore the recvmsg(). b/302741384
maxz-lab
force-pushed
the
cherry-pick-25.lts.1+-3601
branch
from
October 18, 2024 18:07
8451cb1
to
1e5af93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes PR3601 and PR3904 on main branch, and a patch that uses starboard socket on win32.
b/302741384