Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement media::ContentDecryptionModule interface for Starboard #4368

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Implement media::ContentDecryptionModule interface for Starboard #4368

wants to merge 1 commit into from
+858 −602

Conversation

sideb0ard
Copy link
Contributor

@sideb0ard sideb0ard commented Nov 5, 2024 •
edited
Loading

b/328305808

Allows playback of encrypted content by wrapping SbDrm in a media::ContentDecryptionModule interface.

For reviewers - the core StarboardCDM is based heavily on:
https://github.com/youtube/cobalt/blob/25.lts.1%2B/cobalt/media/base/drm_system.h

@sideb0ard sideb0ard requested a review from a team as a code owner November 5, 2024 17:06
@sideb0ard sideb0ard marked this pull request as draft November 5, 2024 17:06
@sideb0ard sideb0ard force-pushed the eme-sbdrm branch 2 times, most recently from 058943b to 2581554 Compare November 7, 2024 22:34
borongc
borongc reviewed Nov 8, 2024
View reviewed changes
media/base/BUILD.gn Outdated Show resolved Hide resolved
borongc
borongc reviewed Nov 8, 2024
View reviewed changes
media/base/BUILD.gn Outdated Show resolved Hide resolved
borongc
borongc reviewed Nov 8, 2024
View reviewed changes
media/cdm/BUILD.gn Outdated Show resolved Hide resolved
borongc
borongc reviewed Nov 8, 2024
View reviewed changes
media/cdm/BUILD.gn Outdated Show resolved Hide resolved
borongc
borongc reviewed Nov 8, 2024
View reviewed changes
media/cdm/BUILD.gn Outdated Show resolved Hide resolved
@sideb0ard sideb0ard marked this pull request as ready for review November 8, 2024 23:26
@sideb0ard sideb0ard changed the title [WIP] SbDrm -> CDM impl Implement media::ContentDecryptionModule interface for Starboard Nov 9, 2024
xiaomings
xiaomings approved these changes Nov 11, 2024
View reviewed changes
.github/CODEOWNERS Outdated Show resolved Hide resolved
media/starboard/starboard_renderer.cc Show resolved Hide resolved
media/starboard/starboard_renderer.cc Outdated Show resolved Hide resolved
media/starboard/starboard_renderer.cc Outdated Show resolved Hide resolved
media/starboard/starboard_renderer.cc Show resolved Hide resolved
media/base/cdm_context.cc Outdated Show resolved Hide resolved
media/cdm/starboard/starboard_cdm.h Outdated Show resolved Hide resolved
media/cdm/starboard/starboard_cdm.cc Outdated Show resolved Hide resolved
media/cdm/starboard/starboard_cdm_session.cc Outdated Show resolved Hide resolved
media/cdm/starboard/starboard_cdm.cc Outdated Show resolved Hide resolved
xiaomings
xiaomings reviewed Nov 12, 2024
View reviewed changes
Copy link
Contributor

@xiaomings xiaomings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't finished reviewing yet, sent out comments so they can be addressed in parallel.

cobalt/build/configs/linux-cobalt-x64x11/args.gn Outdated Show resolved Hide resolved
content/shell/renderer/shell_content_renderer_client.cc Outdated Show resolved Hide resolved
content/shell/renderer/shell_content_renderer_client.cc Outdated Show resolved Hide resolved
media/starboard/starboard_cdm.cc Outdated Show resolved Hide resolved
media/starboard/starboard_cdm.cc Show resolved Hide resolved
media/starboard/starboard_cdm.cc Outdated Show resolved Hide resolved
media/starboard/starboard_cdm.cc Outdated Show resolved Hide resolved
media/starboard/starboard_cdm.cc Show resolved Hide resolved
media/starboard/starboard_cdm.cc Show resolved Hide resolved
media/starboard/starboard_cdm.cc Show resolved Hide resolved
@sideb0ard sideb0ard requested a review from a team as a code owner November 13, 2024 00:16
niranjanyardi
niranjanyardi previously requested changes Nov 13, 2024
View reviewed changes
cobalt/build/configs/chromium_linux-x64x11/args.gn Outdated Show resolved Hide resolved
cobalt/build/configs/chromium_linux-x64x11/args.gn Outdated Show resolved Hide resolved
@sideb0ard sideb0ard force-pushed the eme-sbdrm branch 3 times, most recently from 9e0da51 to 9c513e8 Compare November 13, 2024 16:59
@sideb0ard sideb0ard force-pushed the eme-sbdrm branch 2 times, most recently from dc13e51 to e0c5fec Compare November 13, 2024 18:59
borongc
borongc reviewed Nov 13, 2024
View reviewed changes
media/starboard/starboard_renderer.cc

// |init_cb| will be called inside |CreatePlayerBridge()|.
CreatePlayerBridge(std::move(init_cb));
// TODO(b/378908083) We should only build StarboardRenderer
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to leave it if #4424 is not merged before this PR.

@sideb0ard
b/328305808
4331831 
Allows playback of encrypted content by wrapping SbDrm in a media::ContentDecryptionModule interface.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@borongc borongc borongc left review comments

@briantting briantting Awaiting requested review from briantting briantting is a code owner automatically assigned from youtube/cobalt-3p-repository-owners

@niranjanyardi niranjanyardi Awaiting requested review from niranjanyardi

@xiaomings xiaomings Awaiting requested review from xiaomings

@andrewsavage1 andrewsavage1 Awaiting requested review from andrewsavage1

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sideb0ard @xiaomings @niranjanyardi @andrewsavage1 @borongc