Re-enable CobaltMediaSession #4392
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhongqiliang
requested review from
johnxwork,
yell0wd0g and
kaidokert
and removed request for
johnxwork,
yell0wd0g and
kaidokert
b/377019873
zhongqiliang
force-pushed
the
renable_CobaltMediaSession
branch
from
975a283
to
0915063
Compare
|
The user of the media session API is gone, which used to be go/bugpattern/UnusedMethod has some risks. We'd want to hook this up to the Web API in the same PR and look at everything together. The Web API can either be implemented using the java bridge, or with Starboard Extension(which you have enabled) and blink extension bindings. As Kaido mentioned, there is also a bigger question of how this might duplicate/conflict/supersede Content MediaSession APIs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change re-enabled the CobaltMediaSession in the codebase, it builds, and can start to run.
During my local test, I encountered a crash caused by starboard_renderer.
Abort message: '[7474:7568:1107/131233.523173:FATAL:starboard_renderer.cc(186)] Check failed: !playing_start_from_time_. '
b/377019873