Verify no dangling session IDs in StarboardCDM. #4554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaomings
reviewed
Dec 22, 2024
| @@ -367,10 +367,9 @@ void StarboardCdm::OnSessionUpdated(int ticket, | |||
| } else { | |||
| promises_.RejectPromise(session_update.promise_id, | |||
| CdmPromise::Exception::INVALID_STATE_ERROR, 0, | |||
| "Unable to create CDM."); | |||
| error_message); | |||
There was a problem hiding this comment.
The original Cobalt implementation is to guard the case that CloseSession() is called before the OnSessionUpdateRequestGenerated() is called. The best way to verify this is to create a test web page that generates a update request then immediately close it, add an extra delay in OnSessionUpdateRequestGenerated() callback, so it called after OnSessionClosed(), and see if this is handled correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b/378957649
See bug for full details.
In our previous Cobalt drm_system.cc implementation we held the session update callbacks in a struct, and had to check the session hadn't been destroyed before calling the callbacks.
With the StarboardCDM implementation, those callbacks are passed from CDMSessionAdapter and are protected by being bound to a weak pointer.
I believe we don't have the same issue here and that the session usage looks correct.