Add Android record keycode mapping, and send the key event to Kabuki #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tphamg
approved these changes
May 26, 2023
gbournou
approved these changes
May 26, 2023
y4vor
reviewed
May 30, 2023
There was a problem hiding this comment.
You need to also update the Cobalt DOM keycoces. Those mirror SbKey.
https://github.com/youtube/cobalt/blob/main/cobalt/dom/keycode.h.
Also let's map to "MediaRecord"
https://developer.mozilla.org/en-US/docs/Web/API/UI_Events/Keyboard_event_key_values#multimedia_keys
https://github.com/youtube/cobalt/blob/main/cobalt/dom/keyboard_event.cc#L338
zhongqiliang
force-pushed
the
atv_record_button
branch
3 times, most recently
from
eb9e1ae
to
bc078ea
Compare
|
Added the mapping for DOM keycode. |
zhongqiliang
force-pushed
the
atv_record_button
branch
from
bc078ea
to
f1bd054
Compare
y4vor
approved these changes
May 30, 2023
zhongqiliang
force-pushed
the
atv_record_button
branch
from
f1bd054
to
6b59137
Compare
cobalt-github-releaser-bot
pushed a commit
that referenced
this pull request
Jun 27, 2023
…491) Co-authored-by: Colin Liang <[email protected]> (cherry picked from commit f2f67a5)
zhongqiliang
added a commit
that referenced
this pull request
Jun 27, 2023
… key event to Kabuki (#757) Co-authored-by: Colin Liang <[email protected]> Co-authored-by: Colin Liang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b/272048725
I verified it using adb command to send the keycode.
We need to verify the TV remote record button triggers the keycode AKEYCODE_MEDIA_RECORD(130)