Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gradle error message #577

Merged
merged 1 commit into from
Jun 12, 2023
Merged

Fix gradle error message #577

merged 1 commit into from
Jun 12, 2023

Conversation

zhongqiliang
Copy link
Contributor

@zhongqiliang zhongqiliang commented Jun 8, 2023 •
edited
Loading

The RepositoryHandler.jcenter() method has been deprecated. This is scheduled to be removed in Gradle 8.0. JFrog announced JCenter's sunset in February 2021. Use mavenCentral() instead.

b/286451193

kaidokert
kaidokert approved these changes Jun 9, 2023
View reviewed changes
Copy link
Member

@kaidokert kaidokert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this works, sgtm

@kaidokert kaidokert added the runtest Trigger presubmit workflows. label Jun 9, 2023
@github-actions github-actions bot removed the runtest Trigger presubmit workflows. label Jun 9, 2023
@zhongqiliang
Copy link
Contributor Author

this does not fix the other problem.

@zhongqiliang
Copy link
Contributor Author

Some raspi and sbversion on device tests failed/canceled, I don't think this change impacts them, is it safe to merge?

@zhongqiliang
Copy link
Contributor Author

Submit this change as it should not impact evergreen on device tests.

@zhongqiliang zhongqiliang merged commit 6f334d1 into main Jun 12, 2023
@zhongqiliang zhongqiliang deleted the b/286451193 branch June 12, 2023 17:25
@zhongqiliang zhongqiliang added the cp-24.lts.1+ Cherry Pick to the 24.lts.1+ branch label Jun 27, 2023
cobalt-github-releaser-bot pushed a commit that referenced this pull request Jun 27, 2023
@zhongqiliang @anonymous1-me
Fix gradle error message (#577)
88654d8 
Co-authored-by: Colin Liang <[email protected]>
(cherry picked from commit 6f334d1)
@cobalt-github-releaser-bot cobalt-github-releaser-bot mentioned this pull request Jun 27, 2023
Merged
zhongqiliang added a commit that referenced this pull request Jun 27, 2023
@cobalt-github-releaser-bot @zhongqiliang
Cherry pick PR #577: Fix gradle error message (#756)
20782aa 
Co-authored-by: Colin Liang <[email protected]>
Co-authored-by: Colin Liang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbournou gbournou gbournou approved these changes

@kaidokert kaidokert kaidokert approved these changes

Assignees
No one assigned
Labels
cp-24.lts.1+ Cherry Pick to the 24.lts.1+ branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhongqiliang @kaidokert @gbournou