Moving service worker job related code to its own file. #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sherryzy
reviewed
Jun 14, 2023
There was a problem hiding this comment.
Nice first step! This looks good to me. Thanks for doing the refactor job. Would love @jellefoks to take a look as well.
jellefoks
approved these changes
Jun 17, 2023
kaidokert
requested changes
Jun 17, 2023
b/286597506 Change-Id: I0ca3ac56d3f1e1acdc6fd2cd8faac34a463b8d61
aee-google
force-pushed
the
refactor-service-worker-jobs
branch
from
c3d2d56
to
ab2a2d4
Compare
kaidokert
approved these changes
Jun 21, 2023
cobalt-github-releaser-bot
pushed a commit
that referenced
this pull request
Jun 27, 2023
b/286597506 Change-Id: I0ca3ac56d3f1e1acdc6fd2cd8faac34a463b8d61 (cherry picked from commit 6e280c8)
aee-google
added a commit
to aee-google/cobalt
that referenced
this pull request
Jul 5, 2023
b/286597506 Change-Id: I0ca3ac56d3f1e1acdc6fd2cd8faac34a463b8d61 (cherry picked from commit 6e280c8)
aee-google
added a commit
that referenced
this pull request
Jul 6, 2023
b/286597506 Change-Id: I0ca3ac56d3f1e1acdc6fd2cd8faac34a463b8d61 (cherry picked from commit 6e280c8)
aee-google
added a commit
that referenced
this pull request
Jul 6, 2023
b/286597506 Change-Id: I0ca3ac56d3f1e1acdc6fd2cd8faac34a463b8d61 (cherry picked from commit 6e280c8)
aee-google
added a commit
that referenced
this pull request
Jul 6, 2023
b/286597506 Change-Id: I0ca3ac56d3f1e1acdc6fd2cd8faac34a463b8d61 (cherry picked from commit 6e280c8) Co-authored-by: aee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b/286597506
Change-Id: I0ca3ac56d3f1e1acdc6fd2cd8faac34a463b8d61