Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress warning in Win32 VS 2022 Cobalt Build #644

Merged
merged 2 commits into from
Jun 21, 2023

Conversation

arjungm
Copy link
Contributor

@arjungm arjungm commented Jun 15, 2023

b/265873968

starboard/build/config/BUILD.gn Outdated Show resolved Hide resolved
@arjungm arjungm force-pushed the arjun/fix-win-vs2022-build branch 2 times, most recently from 6bb1aeb to 2628521 Compare June 20, 2023 17:51
@arjungm arjungm force-pushed the arjun/fix-win-vs2022-build branch from 2628521 to 7ab98a0 Compare June 20, 2023 22:39
Copy link
Member

@kaidokert kaidokert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it builds, i'm all for no PDBs

@arjungm arjungm merged commit b5a0219 into youtube:main Jun 21, 2023
@arjungm arjungm deleted the arjun/fix-win-vs2022-build branch June 21, 2023 22:40
dmytro-golovchenko-luminartech pushed a commit to dmytro-golovchenko-luminartech/cobalt that referenced this pull request Jun 22, 2023
@arjungm arjungm added the cp-24.lts.1+ Cherry Pick to the 24.lts.1+ branch label Jun 27, 2023
cobalt-github-releaser-bot pushed a commit that referenced this pull request Jun 27, 2023
b/265873968

(cherry picked from commit b5a0219)
arjungm added a commit that referenced this pull request Jun 27, 2023
b/265873968

(cherry picked from commit b5a0219)
arjungm added a commit that referenced this pull request Jun 28, 2023
b/265873968

(cherry picked from commit b5a0219)
arjungm added a commit that referenced this pull request Jun 28, 2023
…765)

b/265873968

(cherry picked from commit b5a0219)

Co-authored-by: Arjun Menon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cp-24.lts.1+ Cherry Pick to the 24.lts.1+ branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants