-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suppress warning in Win32 VS 2022 Cobalt Build #644
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewsavage1
requested changes
Jun 15, 2023
arjungm
force-pushed
the
arjun/fix-win-vs2022-build
branch
2 times, most recently
from
June 20, 2023 17:51
6bb1aeb
to
2628521
Compare
niranjanyardi
approved these changes
Jun 20, 2023
andrewsavage1
approved these changes
Jun 20, 2023
arjungm
force-pushed
the
arjun/fix-win-vs2022-build
branch
from
June 20, 2023 22:39
2628521
to
7ab98a0
Compare
kaidokert
approved these changes
Jun 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if it builds, i'm all for no PDBs
dmytro-golovchenko-luminartech
pushed a commit
to dmytro-golovchenko-luminartech/cobalt
that referenced
this pull request
Jun 22, 2023
b/265873968 Former-commit-id: b5a0219
cobalt-github-releaser-bot
pushed a commit
that referenced
this pull request
Jun 27, 2023
b/265873968 (cherry picked from commit b5a0219)
arjungm
added a commit
that referenced
this pull request
Jun 27, 2023
b/265873968 (cherry picked from commit b5a0219)
arjungm
added a commit
that referenced
this pull request
Jun 28, 2023
b/265873968 (cherry picked from commit b5a0219)
arjungm
added a commit
that referenced
this pull request
Jun 28, 2023
…765) b/265873968 (cherry picked from commit b5a0219) Co-authored-by: Arjun Menon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b/265873968