Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix undefined argument evaluation order bug. #705

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

gbournou
Copy link
Contributor

b/288627621

@gbournou gbournou requested review from joeltine and TyHolc June 26, 2023 04:00
@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Merging #705 (12f78b9) into main (14f58b6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #705   +/-   ##
=======================================
  Coverage   56.50%   56.51%           
=======================================
  Files        1897     1897           
  Lines       94210    94213    +3     
=======================================
+ Hits        53235    53241    +6     
+ Misses      40975    40972    -3     
Impacted Files Coverage Δ
...r/metrics/cobalt_metrics_services_manager_client.h 66.66% <ø> (ø)
.../metrics/cobalt_metrics_services_manager_client.cc 81.81% <100.00%> (+1.81%) ⬆️

... and 4 files with indirect coverage changes

@joeltine
Copy link
Contributor

Thank you!

@gbournou gbournou merged commit 79e149d into youtube:main Jun 26, 2023
349 checks passed
@gbournou gbournou deleted the telemetry_crash branch June 26, 2023 15:09
@gbournou gbournou added the cp-24.lts.1+ Cherry Pick to the 24.lts.1+ branch label Jun 27, 2023
cobalt-github-releaser-bot pushed a commit that referenced this pull request Jun 27, 2023
b/288627621

(cherry picked from commit 79e149d)
gbournou added a commit that referenced this pull request Jun 27, 2023
b/288627621

(cherry picked from commit 79e149d)

Co-authored-by: Garo Bournoutian <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cp-24.lts.1+ Cherry Pick to the 24.lts.1+ branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants