Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nplb] Fix VerticalVideoTests error #742

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

osagie98
Copy link
Contributor

Changes param instantiation to TEST_SUITE_P to avoid an instantiation error.

b/248859788

Change-Id: Ie5e5ef8841f670ac9661a6e26af3e60dd7d3aa88

@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #742 (ca1aac1) into main (97f8e83) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #742      +/-   ##
==========================================
+ Coverage   56.50%   56.51%   +0.01%     
==========================================
  Files        1897     1897              
  Lines       94211    94210       -1     
==========================================
+ Hits        53237    53246       +9     
+ Misses      40974    40964      -10     

see 7 files with indirect coverage changes

Adds macro to allow both parameterized and non-parameterized tests to
exist in the same test suite.

b/248859788

Change-Id: Ie5e5ef8841f670ac9661a6e26af3e60dd7d3aa88
@sideb0ard sideb0ard self-assigned this Jun 27, 2023
@sideb0ard sideb0ard self-requested a review June 27, 2023 21:17
Copy link
Contributor

@sideb0ard sideb0ard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@osagie98 osagie98 merged commit 19d45e9 into youtube:main Jun 27, 2023
349 checks passed
@osagie98 osagie98 deleted the fix-verticalvideotest branch June 27, 2023 21:19
@osagie98 osagie98 added the cp-24.lts.1+ Cherry Pick to the 24.lts.1+ branch label Jun 27, 2023
cobalt-github-releaser-bot pushed a commit that referenced this pull request Jun 27, 2023
Adds macro to allow both parameterized and non-parameterized tests to
exist in the same test suite.

b/248859788

Change-Id: Ie5e5ef8841f670ac9661a6e26af3e60dd7d3aa88
(cherry picked from commit 19d45e9)
osagie98 added a commit that referenced this pull request Jun 27, 2023
Adds macro to allow both parameterized and non-parameterized tests to
exist in the same test suite.

b/248859788

Change-Id: Ie5e5ef8841f670ac9661a6e26af3e60dd7d3aa88
(cherry picked from commit 19d45e9)

Co-authored-by: Austin Osagie <[email protected]>
sideb0ard pushed a commit to sideb0ard/cobalt that referenced this pull request Sep 6, 2023
e61745a6b7 Re-release
db361a0bb9 Re-add python bindings to sources tarball
d518e55ba7 Update README.md
d052918255 Fix build files (youtube#829)
665e81dc9b New version: 1.0.8 (youtube#827)
223d80cfbe Update (youtube#826)
0c5603e07b Fix output parameter type for _BitScanReverse (youtube#819)
e8155d67b0 CMake: change default ("") build type to Release (youtube#818)
fc823290a7 Mute strerror/strcpy warnings is MSVC build. (youtube#815)
5519352661 Add workaround for lying feof. (youtube#814)
d2ea198232 Update platform.h (youtube#813)
31754d4ffc Add runtime linker path to pkg-config files (youtube#740)
8f093f5e84 .gitignore: Ignore .obj files (youtube#805)
f0db711f46 Filter sources for the tarball. (youtube#808)
7f740f1308 Update (youtube#807)
f83aa5169e Update bazel to 2.2 + update config (youtube#798)
924b2b2b9d Move TZCNT and BSR intrinsics to platform.h, add MSVC versions (youtube#636)
0503d8b766 Added go.mod file to go/cbrotli directory (youtube#754)
f503cb709c Add HAVE_LOG2 build macro (youtube#783)
36ac0feaf9 Adding CIFuzz (youtube#797)
666c3280cc Make types of variable match (youtube#796)
4b5771bee7 Add missing "const" to a couple of kConstants (youtube#780)
c435f06675 Add vcpkg installation instructions (youtube#776)
5c3a9a937b Fix license in setup.py (youtube#769)
afc4a74273 Add oss-fuzz fuzzing status badge to README (youtube#767)
35ef5c554d Disable PIC in EMCC mode. (youtube#768)
ca21dac8e5 Add an option to avoid building shared libraries. (youtube#766)
3d1767186d Fix include for EMCC build (youtube#765)
f1124c8524 More careful sanitizer detection (youtube#764)
c8b37e8fd1 Update (youtube#762)
40f0fdcdc1 Explicitly mark tests/testdata/* as binary. (youtube#761)
78e7bbc3c3 Update (youtube#753)
4b2b2d4f83 Update (youtube#749)
9cd01c0437 Update WORKSPACE files. (youtube#742)
8109882ecf Fix youtube#741
5805f99a53 Ensure decompression consumes all input (youtube#730)
d0ffe60b87 Verbose CLI + start pulling "Shared-Brotli" (youtube#722)
d6d98957ca Ramp up version to 1.0.7
a1e44975a7 Fix youtube#698
a799e34c7f Remove dependency to full JDK. This should speedup clean builds. (youtube#719)
7a153ebb09 make/build: ensure NEON is enabled and tested (youtube#718)
ce8951c3e9 Fix `<arm_neon.h>` inclusion guard. (youtube#717)
f7cbc97c96 Fix typo / minor formatting (youtube#716)
cc7a74f15f decode: fix NEON inclusion (youtube#714)
c94c6f805c tools/brotli: improve window size autodetect (youtube#710)
9402ac5c08 decode: faster huffman code loading on 32-bit Arm (youtube#703)
67f059eaf5 Cross compilation support (youtube#709)
6eba239a5b Fix auto detect of bundled mode (youtube#704)
2216a0dd63 Update (youtube#706)
d4cd6cdf1c platform: fix unaligned 64-bit accesses on AArch32 (youtube#702)
8a073bd9e2 Revert "platform: fix unaligned 64-bit accesses on AArch32 (youtube#699)" (youtube#701)
6d027d1648 platform: fix unaligned 64-bit accesses on AArch32 (youtube#699)
fc4d345968 Fix missing header files (youtube#695)
b601fe817b Ramp up version to 1.0.5
ee2a5e1540 Update go_library to use standard importpath (youtube#690)
eb12ec04eb Update (youtube#688)
7505290ef9 Convert fuzzer to C99. (youtube#686)
ff05c35166 Add VS2017 release Appveyor build (youtube#685)
09cd3e877f Update
8544ae858d Update (youtube#680)
1e7ea1d8e6 Inverse bazel project/workspace tree (youtube#677)
29dc2cce90 Update golang and JS Bazel plugins to latest stable versions. (youtube#676)
f9b8c02673 Add RISC-V 64-bit (riscv64) platform configuration (youtube#669)
48a25b3fa4 Fix youtube#671 (youtube#672)
a4581c158e Add tools to download and transform static dictionary data. (youtube#670)
f5ed35d065 Update (youtube#664)
f94cd51b5c appveyor: fix issue self-upgradig pip to v10 (youtube#663)
6000396155 Remove unprefixed macros from public headers (youtube#662)
68db5c0272 Update (youtube#660)
c6333e1e79 Fix MSVC compilation (youtube#657)
0f3c84e745 Update (youtube#656)
515fc62313 Tell CMake to not check for a C++ compiler (youtube#653)
2c03482569 Fix "memory leak" in python tests (youtube#652)
a238f5bac9 Update README.md (youtube#646)
631fe194a1 Update (youtube#651)
533843e354 Update (youtube#643)
35e69fc7cf New feature: "Large Window Brotli" (youtube#640)

git-subtree-dir: third_party/brotli
git-subtree-split: e61745a6b7add50d380cfd7d3883dd6c62fc2c71
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cp-24.lts.1+ Cherry Pick to the 24.lts.1+ branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants