Cherry pick PR #715: Fix gtest multithread crash #743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…os (#715) on multiple threads. The failures will be correctly reported and no longer crashes the app. When GoogleTest is used in multi-thread mode (i.e. its macros are used on thread other than the main thread), it may crash as GetTestPartResultReporterForCurrentThread() returns nullptr on a forked thread. This is due to that the ThreadLocal class in our GTEST_OS_STARBOARD implementation doesn't return the default value on newly created threads The ThreadLocal ctor accepts a default value of T to be returned on a thread where the thread local value hasn't been overridden. The existing implementation incorrectly returns T() on a new thread where the value has never been set. When T is a pointer, T() is nullptr and causes crash when dereferenced. Now the default value to ThreadLocal ctor is stored and a copy of it will be returned on a new thread when the thread local value hasn't been set. This ensures that GetTestPartResultReporterForCurrentThread() returns the correct TestPartResultReporterInterface*, and failures of GoogleTest's ASSERT and EXPECT macros on a different thread will be correctly reported and no longer crashes the app. b/230877781 Change-Id: Ibb5ced5611593092d6065af4474027404a783caa (cherry picked from commit 0c9c2cf)
WeiChungChang
approved these changes
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Refer to the original PR: #715"