Cherry pick PR #685: Creates build_info.json alongside cobalt_build_id. #751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Creates build_info.json alongside cobalt_build_id. Creates build_info.json alongside the logic that creates cobalt_build_id.h. This offloads generating build_info.json from the CI system to GN and updates build_info.json with the build_id, build_rev, git_rev, build_time, author, and commit fields. On Git repos, git_rev is equivalent to build_rev. On Gerrit repos, git_rev represents the last Git hash synced, tied with Git build_id. b/284367797 * Refactored to preserve backwards compatibility. b/284367797 (cherry picked from commit e460715)
briantting
approved these changes
Jun 27, 2023
kaidokert
reviewed
Jun 27, 2023
kaidokert
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Refer to the original PR: #685"