Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nplb] Increase max pending buffers in resampler #752

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

jasonzhangxx
Copy link
Contributor

Increase kMaximumPendingBuffers in InterleavedSincResampler to fix failed partial audio tests.

b/274020873
b/289102877

Increase kMaximumPendingBuffers in InterleavedSincResampler to fix failed
partial audio tests.

b/274020873
b/289102877
@jasonzhangxx jasonzhangxx self-assigned this Jun 27, 2023
@jasonzhangxx jasonzhangxx removed their assignment Jun 27, 2023
@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #752 (28b4d72) into main (5c40b4f) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #752      +/-   ##
==========================================
+ Coverage   56.49%   56.50%   +0.01%     
==========================================
  Files        1897     1897              
  Lines       94209    94210       +1     
==========================================
+ Hits        53222    53235      +13     
+ Misses      40987    40975      -12     
Impacted Files Coverage Δ
...rboard/player/filter/interleaved_sinc_resampler.cc 83.59% <ø> (ø)
...arboard/player/filter/interleaved_sinc_resampler.h 100.00% <ø> (ø)

... and 5 files with indirect coverage changes

@jasonzhangxx jasonzhangxx merged commit 4a0aee2 into youtube:main Jun 27, 2023
@jasonzhangxx jasonzhangxx deleted the resample-crash branch June 27, 2023 21:49
@jasonzhangxx jasonzhangxx added the cp-24.lts.1+ Cherry Pick to the 24.lts.1+ branch label Jun 27, 2023
cobalt-github-releaser-bot pushed a commit that referenced this pull request Jun 27, 2023
Increase kMaximumPendingBuffers in InterleavedSincResampler to fix failed
partial audio tests.

b/274020873
b/289102877

(cherry picked from commit 4a0aee2)
jasonzhangxx added a commit that referenced this pull request Jun 27, 2023
Increase kMaximumPendingBuffers in InterleavedSincResampler to fix failed
partial audio tests.

b/274020873
b/289102877

(cherry picked from commit 4a0aee2)

Co-authored-by: Jason <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cp-24.lts.1+ Cherry Pick to the 24.lts.1+ branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants