Use persistent settings for telemetry controls. #755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows telemetry state to persist through app lifecycles (important since the web app has a different lifecyle). b/286898092 Change-Id: I819f8d31420af8d6c9d4f2ce7f5afeada893fd0e
gbournou
suggested changes
Jun 27, 2023
Codecov Report
@@ Coverage Diff @@
## main #755 +/- ##
==========================================
- Coverage 56.51% 56.51% -0.01%
==========================================
Files 1897 1897
Lines 94210 94218 +8
==========================================
Hits 53243 53243
- Misses 40967 40975 +8
|
b/286898092 Change-Id: Idb96655fc9bb56cf04a6a0c29e481ea824fcc47f
gbournou
approved these changes
Jun 28, 2023
cobalt-github-releaser-bot
pushed a commit
that referenced
this pull request
Jun 28, 2023
* Use persistent settings for telemetry controls. This allows telemetry state to persist through app lifecycles (important since the web app has a different lifecyle). b/286898092 Change-Id: I819f8d31420af8d6c9d4f2ce7f5afeada893fd0e * Remove is_enabled_ and set interval default b/286898092 Change-Id: Idb96655fc9bb56cf04a6a0c29e481ea824fcc47f (cherry picked from commit ff1b81e)
joeltine
added a commit
that referenced
this pull request
Jun 28, 2023
…768) * Use persistent settings for telemetry controls. This allows telemetry state to persist through app lifecycles (important since the web app has a different lifecyle). b/286898092 Change-Id: I819f8d31420af8d6c9d4f2ce7f5afeada893fd0e * Remove is_enabled_ and set interval default b/286898092 Change-Id: Idb96655fc9bb56cf04a6a0c29e481ea824fcc47f (cherry picked from commit ff1b81e) Co-authored-by: Joel Martinez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows telemetry state to persist through app lifecycles (important since the web app has a different lifecyle).
b/286898092
Change-Id: I819f8d31420af8d6c9d4f2ce7f5afeada893fd0e