Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry pick PR #644: Suppress warning in Win32 VS 2022 Cobalt Build #765

Merged
merged 1 commit into from
Jun 28, 2023
Merged

Cherry pick PR #644: Suppress warning in Win32 VS 2022 Cobalt Build #765

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion starboard/build/config/win/BUILD.gn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,13 @@ config("host") {
}

config("common") {
configs = []

if (!cobalt_fastbuild) {
# Containers cannot use PDBs, so we conditionally disable them.
# We want to keep them for non-docker builds as they make compilation
# significantly faster.
configs = [ ":no_pdbs" ]
configs += [ ":no_pdbs" ]
}

cflags_cc = [ "/TP" ]
Expand All @@ -41,6 +43,9 @@ config("common") {
"UNICODE",
]

# Allows compilation against VS 2022.
configs += [ "//build/config/win:visual_studio_version_compat" ]

# msvs_base
# OutputDirectory and IntermediateDirectory, maybe CharacterSet
include_dirs += [
Expand Down