Skip to content

Commit

Permalink
stop defining _LIBCPP_ENABLE_CXX17_REMOVED_UNEXPECTED_FUNCTIONS when …
Browse files Browse the repository at this point in the history
…building libc++abi

This was needed because libc++'s <exception> header omits
set_unexpected() (which libcxxabi defines) if that define isn't
set -- but <exception> also doesn't omit it if _LIBCPP_BUILDING_LIBRARY
is defined, which it is after
https://chromium-review.googlesource.com/c/chromium/src/+/3469341

No behavior change.

Bug: 1298070
Change-Id: I6b289656dc9bbc3a5428ac288bda54755bcf221d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3472583
Commit-Queue: Nico Weber <[email protected]>
Auto-Submit: Nico Weber <[email protected]>
Reviewed-by: Arthur Eubanks <[email protected]>
Commit-Queue: Arthur Eubanks <[email protected]>
Cr-Commit-Position: refs/heads/main@{#972605}
  • Loading branch information
nico authored and Chromium LUCI CQ committed Feb 17, 2022
1 parent d0430d4 commit 6e3c300
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion buildtools/third_party/libc++abi/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@ source_set("libc++abi") {

defines = [
"LIBCXXABI_SILENT_TERMINATE",
"_LIBCPP_ENABLE_CXX17_REMOVED_UNEXPECTED_FUNCTIONS",

# TODO(crbug.com/1298070) _LIBCPP_CONSTINIT is defined in a libc++ revision
# more recent than the one currently used in Chromium.
Expand Down

0 comments on commit 6e3c300

Please sign in to comment.