Skip to content

Commit

Permalink
Remove starboard/atomic.h (#4369)
Browse files Browse the repository at this point in the history
b/369181947
  • Loading branch information
y4vor authored Nov 5, 2024
1 parent 3830e65 commit 9c34fa0
Show file tree
Hide file tree
Showing 12 changed files with 3 additions and 2,128 deletions.
1 change: 0 additions & 1 deletion starboard/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,6 @@ source_set("starboard_headers_only") {
check_includes = false

sources = [
"atomic.h",
"audio_sink.h",
"configuration.h",
"configuration_constants.h",
Expand Down
1 change: 1 addition & 0 deletions starboard/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ Starboard 17 fully switches to POSIX APIs.
### Removed `starboard/accessibility.h`
The functionality is migrated to a starboard extension.

### Removed `starboard/atomic.h`
### Removed `starboard/byte_swap.h`
### Removed `starboard/condition_variable.h`
### Removed `starboard/directory.h`
Expand Down
8 changes: 2 additions & 6 deletions starboard/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ With subdirectories:
* `shared/` - For code shared between architectures within a product family.
* `<binary-variant>/` - For any code that is specific to a specific binary
variant. Each one of these must at least have `BUILD.gn`,
`configuration_public.h`, `atomic_public.h`,
`configuration_public.h`,
`platform_configuration/BUILD.gn`,
`platform_configuration/configuration.gni`, and `toolchain/BUILD.gn` files.

Expand All @@ -104,7 +104,6 @@ In the BobCo's BobBox example, we would see something like:
* `configuration.gni`
* `toolchain/`
* `BUILD.gn`
* `atomic_public.h`
* `BUILD.gn`
* `configuration_public.h`
* `armel/`
Expand All @@ -113,7 +112,6 @@ In the BobCo's BobBox example, we would see something like:
* `configuration.gni`
* `toolchain/`
* `BUILD.gn`
* `atomic_public.h`
* `BUILD.gn`
* `configuration_public.h`

Expand Down Expand Up @@ -162,7 +160,7 @@ In order to use a new platform configuration in a build, you need to ensure that
you have a `BUILD.gn`, `toolchain/BUILD.gn`,
`platform_configuration/configuration.gni`, and
`platform_configuration/BUILD.gn` in their own directory for each binary
variant, plus the header files `configuration_public.h` and `atomic_public.h`.
variant, plus the header files `configuration_public.h`.
You must add your platform name to `starboard/build/platforms.py` along with
the path to the port to be able to build it.

Expand Down Expand Up @@ -196,8 +194,6 @@ the path to the port to be able to build it.
as appropriate for your platform.
1. Update `BUILD.gn` to point at all the source files you want to build as
part of your new Starboard implementation (as mentioned above).
1. Update `atomic_public.h` as necessary to point
at the appropriate shared or custom implementations.

If you want to use `cobalt/build/gn.py`, you'll also need a
`third_party/starboard/<family-name>/<binary-variant>/args.gn` file. This
Expand Down
1 change: 0 additions & 1 deletion starboard/android/shared/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ shared_library("starboard_jni_state") {
static_library("starboard_platform") {
sources = [
"//starboard/shared/egl/system_egl.cc",
"//starboard/shared/gcc/atomic_gcc_public.h",
"//starboard/shared/gles/gl_call.h",
"//starboard/shared/gles/system_gles2.cc",
"//starboard/shared/internal_only.h",
Expand Down
259 changes: 0 additions & 259 deletions starboard/atomic.h

This file was deleted.

Loading

0 comments on commit 9c34fa0

Please sign in to comment.