Skip to content

Commit

Permalink
Use same debug symbol configuration for win and xb1 (#3921)
Browse files Browse the repository at this point in the history
b/302741384

This adds pdb's for debugging locally for win32
  • Loading branch information
niranjanyardi committed Aug 2, 2024
1 parent 98a0b5e commit a4dadc8
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
3 changes: 3 additions & 0 deletions starboard/win/shared/platform_configuration/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,9 @@ config("platform_configuration") {
# Suppress import library warning caused by the win32/posix_emu
"/ignore:4286",
]
if (is_qa || is_gold || !cobalt_fastbuild) {
ldflags += [ "/DEBUG:FASTLINK" ]
}

if (cobalt_pending_clean_up) {
# TODO: b/330363799 - These were added for the base/net update and should
Expand Down
4 changes: 0 additions & 4 deletions starboard/xb1/platform_configuration/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -60,10 +60,6 @@ config("target") {
]
}

if (is_qa || is_gold || !cobalt_fastbuild) {
ldflags += [ "/DEBUG:FASTLINK" ]
}

ldflags += [ "/NODEFAULTLIB" ]
arflags += [ "/NODEFAULTLIB" ]
libs += [
Expand Down

0 comments on commit a4dadc8

Please sign in to comment.