Skip to content

Commit

Permalink
Cherry pick PR #2093: [nplb] Increase PartialAudio test segment size …
Browse files Browse the repository at this point in the history
…(#2097)

Refer to the original PR: youtube/cobalt#2093

We may see performance issue if segment size is too small. A segment
size of 0.1 would ask the platform to decode 10x audio units. A segment
size of 0.3 makes more sense as it ask the platform to decode 4x audio
units, which could happen when we have partial audio units with playback
speed of 2x.

b/313782907

Co-authored-by: Jason <[email protected]>
  • Loading branch information
cobalt-github-releaser-bot and jasonzhangxx authored Dec 15, 2023
1 parent 7fe808c commit e1a2dc6
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion starboard/nplb/player_write_sample_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ TEST_P(SbPlayerWriteSampleTest, PartialAudio) {
}

const SbTime kDurationToPlay = kSbTimeSecond;
const float kSegmentSize = 0.1f;
const float kSegmentSize = 0.3f;

GroupedSamples samples;
if (player_fixture.HasVideo()) {
Expand Down

0 comments on commit e1a2dc6

Please sign in to comment.