Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce ODT specific repo vars. #383

Closed
wants to merge 28 commits into from
Closed

Conversation

isarkis
Copy link
Member

@isarkis isarkis commented Apr 24, 2023

No description provided.

y4vor and others added 27 commits March 24, 2023 20:04
This updates webdriver links to their new locations, with versioning.

b/200993308
This is a test commit.

b/276483058
* Add unit test report workflow

* Fix download path
Change concurrency setting to make sure workflows of different
event types (e.g. pull_request, push, workflow_dispatch) do not
cancel each other.

b/278386358
The latest version of python in chocolatey is 3.11.2 which has a
regression that makes it ignore install arguments such as TargetDir.
This breaks the docker build since the Python installation directory is
no longer C:\Python3.

As a workaround, we pin the version to 3.11.0, which address the issue.
Ideally we would remove the pinned version if it is addressed at a later
time.

b/276772883
* Test Copybara double workflow

* Update README.md
* Test copybara references

* Update README.md
* Concurrency fix for forked PRs.

* Follow up commit.
* Cure it all

* Update starboard_configuration.py
* Add label based cherry pick workflow

b/278602512
@isarkis isarkis force-pushed the odt_vars branch 3 times, most recently from e69f382 to 158b044 Compare April 24, 2023 19:55
kaidokert added a commit that referenced this pull request May 16, 2023
This switches Windows workers, which are not yet ephemeral to use
a patched version of checkouts.

This guarantees always cleaning up repo state even in case of
previous bad submodules-like repo operations done by a previous
run.

In the long run, we should be using ephemeral workers, and switch
to upstream fixed version if the PR gets merged upstream.

Upstream PR: actions/checkout#1321

b/282361986
b/258687270
copybara-service bot pushed a commit that referenced this pull request May 17, 2023
…386)

This switches Windows workers, which are not yet ephemeral to use
a patched version of checkouts.

This guarantees always cleaning up repo state even in case of
previous bad submodules-like repo operations done by a previous
run.

In the long run, we should be using ephemeral workers, and switch
to upstream fixed version if the PR gets merged upstream.

Upstream PR: actions/checkout#1321

b/282361986
b/258687270

(cherry picked from commit 3c24834)

Co-authored-by: Kert <[email protected]>
kaidokert added a commit to kaidokert/cobalt_sandbox that referenced this pull request May 18, 2023
…e#383)

This switches Windows workers, which are not yet ephemeral to use
a patched version of checkouts.

This guarantees always cleaning up repo state even in case of
previous bad submodules-like repo operations done by a previous
run.

In the long run, we should be using ephemeral workers, and switch
to upstream fixed version if the PR gets merged upstream.

Upstream PR: actions/checkout#1321

b/282361986
b/258687270
kaidokert added a commit that referenced this pull request May 22, 2023
This uses the patched workaround version of checkout action to
sidestep submodules issues. In original PR #383 we only fixed
Windows workflows that had issues due to persistent runners, but
similar problems also trip on Linux/other builds.

b/282361986
kaidokert added a commit that referenced this pull request May 22, 2023
This uses the patched workaround version of checkout action to
sidestep submodules issues. In original PR #383 we only fixed
Windows workflows that had issues due to persistent runners, but
similar problems also trip on Linux/other builds.

b/282361986
@oxve oxve force-pushed the main branch 2 times, most recently from 4fca35b to 2e8c30c Compare November 16, 2023 23:41
@kaidokert kaidokert closed this Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.