Testing vars

.github/workflows/evergreen.yaml

@@ -11,7 +11,7 @@ on:
       - main
       - feature/*
   schedule:
-    - cron: '0 4 * * *'
+    - cron: '0 6 * * *'
   workflow_dispatch:
     inputs:
       nightly:
@@ -20,7 +20,22 @@ on:
         type: boolean
         default: false
 
+env:
+  RUN_ODT_TESTS_ON_NIGHTLY: ${{ vars.RUN_ODT_TESTS_ON_NIGHTLY }}
+  RUN_ODT_TESTS_ON_POSTSUBMIT: ${{ vars.RUN_ODT_TESTS_ON_POSTSUBMIT }}
+
 jobs:
+  varshow:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Run a multi-line script
+        run: |
+          echo Add other actions to build,
+          echo test, and deploy your project.
+          echo "${{ vars.RUN_ODT_TESTS_ON_NIGHTLY }}"
+          echo "${{ vars.RUN_ODT_TESTS_ON_NIGHTLY }}"
+          echo "${{ env.RUN_ODT_TESTS_ON_POSTSUBMIT }}"
+          echo "${{ env.RUN_ODT_TESTS_ON_POSTSUBMIT }}"
   evergreen-x64:
     uses: ./.github/workflows/main.yaml
     permissions:

.github/workflows/label-cherry-pick.yaml

@@ -0,0 +1,87 @@
+name: Label Cherry Pick
+
+on:
+  pull_request_target:
+    types:
+      - labeled
+      - closed
+
+jobs:
+  prepare_branch_list:
+    runs-on: ubuntu-latest
+    outputs:
+      target_branch: ${{ steps.set-branches.outputs.target_branch }}
+    steps:
+    - name: Set Branches
+      id: set-branches
+      env:
+        PR_LABELS: ${{ toJson(github.event.pull_request.labels) }}
+        EVENT_ACTION: ${{ github.event.action }}
+        LABEL_NAME: ${{ github.event.label.name }}
+        BASE_REF: ${{ github.base_ref }}
+      run: |
+        if [[ $EVENT_ACTION == 'closed' ]]; then
+          labels=$(echo "$PR_LABELS" | jq -r '.[].name')
+        else
+          labels=$LABEL_NAME
+        fi
+
+        branches=("23.lts.1+" "22.lts.1+" "21.lts.1+", "20.lts.1+" "19.lts.1+" "19.android.1+" "rc_11" "COBALT_9")
+        filtered_branches=()
+        for branch in "${branches[@]}"; do
+          if [[ $branch == $BASE_REF ]]; then
+            continue
+          fi
+
+          for label in $labels; do
+            if [[ $label == "cp-$branch" ]]; then
+              filtered_branches+=("$branch")
+            fi
+          done
+        done
+
+        echo "target_branch=$(echo -n "$filtered_branches" | jq -cRs 'split("\n")')" >> $GITHUB_OUTPUT
+
+  cherry_pick:
+    runs-on: ubuntu-latest
+    needs: prepare_branch_list
+    if: |
+      needs.prepare_branch_list.outputs.target_branch != '[]' &&
+      github.event.pull_request.merged == true &&
+      github.event.pull_request.merge_commit_sha != null
+    strategy:
+      matrix:
+        target_branch: ${{ fromJson(needs.prepare_branch_list.outputs.target_branch) }}
+    env:
+      ACCESS_TOKEN: ${{ secrets.CHERRY_PICK_TOKEN }}
+      REPOSITORY: ${{ github.repository }}
+      GITHUB_REF: ${{ github.ref }}
+      MERGE_COMMIT_SHA: ${{ github.event.pull_request.merge_commit_sha }}
+    steps:
+      - name: Checkout repository
+        uses: actions/checkout@v3
+        with:
+          ref: ${{ matrix.target_branch }}
+          fetch-depth: 0
+
+      - name: Setup Git
+        run: |
+          git config --global user.name "GitHub Release Automation"
+          git config --global user.email "[email protected]"
+
+      - name: Cherry pick merge commit
+        run: |
+          git fetch origin ${{ matrix.target_branch }}
+          git cherry-pick -x $MERGE_COMMIT_SHA
+
+      - name: Create Pull Request
+        uses: peter-evans/create-pull-request@2b011faafdcbc9ceb11414d64d0573f37c774b04 # v4.2.3
+        with:
+          token: ${{ secrets.CHERRY_PICK_TOKEN }}
+          base: ${{ matrix.target_branch }}
+          branch: "${{ matrix.target_branch }}-${{ github.event.pull_request.number }}"
+          committer: GitHub Release Automation <[email protected]>
+          reviewers: ${{ github.event.pull_request.user.login }}
+          title: "Cherry pick PR #${{ github.event.pull_request.number }}: ${{ github.event.pull_request.title }}"
+          body: |
+            "Refer to the original PR: https://github.com/${{ github.repository }}/pull/${{ github.event.pull_request.number }}"

.github/workflows/lint.yaml

@@ -13,7 +13,7 @@ on:
       - feature/*
 
 concurrency:
-  group: '${{ github.workflow }}-${{ inputs.platform }} @ ${{ github.event.pull_request.head.label || github.head_ref || github.sha }}'
+  group: '${{ github.workflow }}-${{ github.event_name }}-${{ inputs.platform }} @ ${{ github.event.pull_request.head.repo.id}}:${{ github.event.pull_request.head.label || github.head_ref || github.sha }}'
   cancel-in-progress: true
 
 permissions: {}

.github/workflows/main.yaml

@@ -32,7 +32,7 @@ env:
   STARBOARD_TOOLCHAINS_DIR: /root/starboard-toolchains
 
 concurrency:
-  group: '${{ github.workflow }}-${{ inputs.platform }} @ ${{ github.event.pull_request.head.label || github.head_ref || github.sha }}'
+  group: '${{ github.workflow }}-${{ github.event_name }}-${{ inputs.platform }} @ ${{ github.event.pull_request.number || github.sha }}'
   cancel-in-progress: true
 
 # A workflow run is made up of one or more jobs that can run sequentially or in parallel

.github/workflows/main_win.yaml

@@ -33,7 +33,7 @@ env:
   STARBOARD_TOOLCHAINS_DIR: /root/starboard-toolchains
 
 concurrency:
-  group: '${{ github.workflow }}-${{ inputs.platform }} @ ${{ github.event.pull_request.head.label || github.head_ref || github.sha }}'
+  group: '${{ github.workflow }}-${{ github.event_name }}-${{ inputs.platform }} @ ${{ github.event.pull_request.head.repo.id}}:${{ github.event.pull_request.head.label || github.head_ref || github.sha }}'
   cancel-in-progress: true
 
 # A workflow run is made up of one or more jobs that can run sequentially or in parallel

.github/workflows/pr_badges.yaml

@@ -14,9 +14,10 @@ on:
       - 'COBALT_9'
 
 concurrency:
-  group: '${{ github.workflow }}-${{ inputs.platform }} @ ${{ github.event.pull_request.head.label || github.head_ref || github.sha }}'
+  group: '${{ github.workflow }}-${{ github.event_name }}-${{ inputs.platform }} @ ${{ github.event.pull_request.head.repo.id}}:${{ github.event.pull_request.head.label || github.head_ref || github.sha }}'
   cancel-in-progress: true
 
+
 permissions:
   pull-requests: write
 

.github/workflows/raspi-2.yaml

@@ -11,7 +11,7 @@ on:
       - main
       - feature/*
   schedule:
-    - cron: '0 4 * * *'
+    - cron: '0 7 * * *'
   workflow_dispatch:
     inputs:
       nightly:
@@ -29,11 +29,11 @@ jobs:
     with:
       platform: raspi-2
       nightly: ${{ github.event.inputs.nightly }}
-  raspi-2-skia:
-    uses: ./.github/workflows/main.yaml
-    permissions:
-      packages: write
-      pull-requests: write
-    with:
-      platform: raspi-2-skia
-      nightly: ${{ github.event.inputs.nightly }}
+  # raspi-2-skia:
+  #  uses: ./.github/workflows/main.yaml
+  #  permissions:
+  #    packages: write
+  #    pull-requests: write
+  #  with:
+  #    platform: raspi-2-skia
+  #    nightly: ${{ github.event.inputs.nightly }}

.github/workflows/test-report.yaml

@@ -0,0 +1,26 @@
+name: 'Test Report'
+on:
+  workflow_run:
+    # runs after main workflow
+    workflows:
+      - evergreen
+      - linux
+      # TODO
+      # - win32
+    types:
+      - completed
+jobs:
+  report:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Download test results
+        uses: actions/download-artifact@v3
+        with:
+          name: unit-test-report
+          path: ${GITHUB_WORKSPACE}/test_results
+      - name: Create Report
+        uses: dorny/test-reporter@c9b3d0e2bd2a4e96aaf424dbaa31c46b42318226
+        with:
+          name: Cobalt Unit Tests
+          path: ${GITHUB_WORKSPACE}/test_results/**/*.xml
+          reporter: jest-junit

.github/workflows/workflow_trigger.yaml

@@ -0,0 +1,48 @@
+name: workflow_trigger
+
+on:
+  workflow_dispatch:
+    inputs:
+      branch:
+        type: choice
+        description: Branch
+        options:
+          - '23.lts.1+'
+          - '22.lts.1+'
+          - '21.lts.1+'
+          - '20.lts.1+'
+          - '19.lts.1+'
+          - 'rc_11'
+          - 'COBALT_9'
+      workflow:
+        type: choice
+        description: Workflow name
+        options:
+          - 'android'
+          - 'evergreen'
+          - 'linux'
+          - 'raspi'
+          - 'win32'
+      nightly:
+        description: 'Nightly workflow.'
+        required: true
+        type: boolean
+        default: false
+
+jobs:
+  trigger:
+    permissions:
+      actions: write
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v3
+        with:
+          fetch-depth: 1
+          ref: ${{github.event.branch}}
+      - name: Trigger Nightly
+        run: |
+          set -x
+          gh workflow run ${{github.event.inputs.workflow}}_${{github.event.inputs.branch}} --ref ${{github.event.inputs.branch}} -f nightly=${{github.event.inputs.nightly}}
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.gitignore

@@ -9,3 +9,4 @@
 /venv/*
 _certs/
 .coverage
+

BUILD.gn

@@ -12,6 +12,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
+
 group("gn_all") {
   testonly = true
 

README.md

@@ -1,7 +1,5 @@
 # Cobalt [![Build Status](https://img.shields.io/badge/-Build%20Status-blueviolet)](https://github.com/youtube/cobalt/blob/main/BUILD_STATUS.md)
 
-Test change
-
 ## Overview
 
 Cobalt is a lightweight application container (i.e. an application runtime, like
@@ -73,6 +71,8 @@ Chromium, FireFox, and IE:
 
 ## Architecture
 
+One more test
+
 The Cobalt Authors forked H5VCC, removed most of the Chromium code -- in
 particular WebCore and the Chrome Renderer and Compositor -- and built up from
 scratch an implementation of a simplified subset of HTML, the CSS Box Model for

cobalt/webdriver/algorithms.cc

@@ -455,7 +455,7 @@ std::string GetElementText(dom::Element* element) {
 }
 
 // There is a spec for "displayedness" available:
-//   https://w3c.github.io/webdriver/webdriver-spec.html#element-displayedness
+//   https://www.w3.org/TR/2015/WD-webdriver-20150808/#element-displayedness
 // However, the algorithm described in the spec does not match existing
 // implementations of WebDriver.
 // IsDisplayed will match the existing implementations, using the implementation

cobalt/webdriver/algorithms.h

@@ -24,13 +24,13 @@ namespace webdriver {
 namespace algorithms {
 
 // Implementation of getElementText algorithm.
-// https://w3c.github.io/webdriver/webdriver-spec.html#getelementtext
+// https://www.w3.org/TR/2015/WD-webdriver-20150808/#getelementtext
 // The spec is not totally clear and, according to comments on the spec, does
 // not exactly match the behavior of existing WebDriver implementations. This
 // implementation will follow the de-facto standards where they differ.
 std::string GetElementText(dom::Element* element);
 
-// https://w3c.github.io/webdriver/webdriver-spec.html#element-displayedness
+// https://www.w3.org/TR/2015/WD-webdriver-20150808/#element-displayedness
 // The spec does not exactly match the behavior of existing WebDriver
 // implementations. Consistency with existing implementations will be preferred
 // over strict conformance to the draft spec.

cobalt/webdriver/dispatcher.h

@@ -76,8 +76,8 @@ class WebDriverDispatcher {
     };
     // Send the result of the execution of a registered WebDriver command to be
     // sent as a response as described in the spec:
-    // https://github.com/SeleniumHQ/selenium/wiki/JsonWireProtocol#Responses
-    // https://github.com/SeleniumHQ/selenium/wiki/JsonWireProtocol#Failed-Commands
+    // https://www.selenium.dev/documentation/legacy/json_wire_protocol/#responses
+    // https://www.selenium.dev/documentation/legacy/json_wire_protocol/#failed-commands
     virtual void SendResult(
         const base::Optional<protocol::SessionId>& session_id,
         protocol::Response::StatusCode status_code,
@@ -95,7 +95,7 @@ class WebDriverDispatcher {
     // Some forms of Invalid Requests are detected in the CommandCallback by
     // checking the path variables and command parameters. Invalid requests are
     // described here:
-    // https://github.com/SeleniumHQ/selenium/wiki/JsonWireProtocol#Invalid-Requests
+    // https://www.selenium.dev/documentation/legacy/json_wire_protocol/#invalid-requests
     //
     // TODO: Invalid requests should be handled before calling the
     //   CommandCallback.

cobalt/webdriver/element_driver.cc

@@ -12,10 +12,10 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#include <memory>
-
 #include "cobalt/webdriver/element_driver.h"
 
+#include <memory>
+
 #include "cobalt/cssom/property_value.h"
 #include "cobalt/cssom/viewport_size.h"
 #include "cobalt/dom/document.h"
@@ -266,14 +266,14 @@ util::CommandResult<void> ElementDriver::SendClickInternal(
     return CommandResult(protocol::Response::kElementNotVisible);
   }
   // Click on an element.
-  //   https://github.com/SeleniumHQ/selenium/wiki/JsonWireProtocol#sessionsessionidelementidclick
+  //   https://www.selenium.dev/documentation/legacy/json_wire_protocol/#sessionsessionidelementidclick
   // The Element Click clicks the in-view center point of the element
-  //   https://w3c.github.io/webdriver/webdriver-spec.html#dfn-element-click
+  //   https://www.w3.org/TR/2015/WD-webdriver-20150808/#click
 
   // An element's in-view center point is the origin position of the rectangle
   // that is the intersection between the element's first DOM client rectangle
   // and the initial viewport.
-  //   https://w3c.github.io/webdriver/webdriver-spec.html#dfn-in-view-center-point
+  //   https://www.w3.org/TR/2017/WD-webdriver-20170125/#dfn-in-view-center-point
   scoped_refptr<dom::DOMRectList> dom_rects = element_->GetClientRects();
   if (dom_rects->length() == 0) {
     return CommandResult(protocol::Response::kElementNotVisible);

cobalt/webdriver/element_driver.h

@@ -46,7 +46,7 @@ class WindowDriver;
 
 // ElementDriver could be considered a WebElement as described in the WebDriver
 // spec.
-// https://github.com/SeleniumHQ/selenium/wiki/JsonWireProtocol#webelement
+// https://www.selenium.dev/documentation/legacy/json_wire_protocol/#webelement
 // Commands that interact with a WebElement, such as:
 //     /session/:sessionId/element/:id/some_command
 // will map to a method on this class.

cobalt/webdriver/protocol/button.h

@@ -27,9 +27,9 @@ namespace protocol {
 
 // Represents the JSON parameters passed to the click, buttondown, and buttonup
 // WebDriver commands.
-// https://github.com/SeleniumHQ/selenium/wiki/JsonWireProtocol#sessionsessionidelementidclick
-// https://github.com/SeleniumHQ/selenium/wiki/JsonWireProtocol#sessionsessionidbuttondown
-// https://github.com/SeleniumHQ/selenium/wiki/JsonWireProtocol#sessionsessionidbuttonup
+// https://www.selenium.dev/documentation/legacy/json_wire_protocol/#sessionsessionidelementidclick
+// https://www.selenium.dev/documentation/legacy/json_wire_protocol/#sessionsessionidbuttondown
+// https://www.selenium.dev/documentation/legacy/json_wire_protocol/#sessionsessionidbuttonup
 class Button {
  public:
   static std::unique_ptr<base::Value> ToValue(const Button& button);