Update cobalt contributing guidelines #462
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaidokert
reviewed
Jun 20, 2023
kaidokert
requested changes
Jun 20, 2023
isarkis
pushed a commit
that referenced
this pull request
Jul 7, 2023
The CHECK for consistency in linked_hash_map::erase() fails in production, where we are unable to find an obvious cause. Now FetcherCache is ref counted to ensure that there isn't any life time issue, and extra CHECKs are added so we can have more information about the crash once released. b/270993319 (cherry picked from commit dd3705f) Co-authored-by: xiaomings <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.