Comment on cherry pick PR on failure #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b/301453749
oxve
added a commit
that referenced
this pull request
Sep 29, 2023
* Squashed 'components/version_info/' content from commit 737f4cc3d914 git-subtree-dir: components/version_info git-subtree-split: 737f4cc3d91409d092991dc6834788b9e4c5613a * Squashed 'extensions/buildflags/' content from commit 835b1103d31b git-subtree-dir: extensions/buildflags git-subtree-split: 835b1103d31bdb8a2df943e3c837099a79e930ad * Whitespace to trigger bots No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Ib15dd68154821b937d2b28f62411ba09b88e0b39 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2050235 Reviewed-by: Liviu Rau <[email protected]> git-subtree-dir: third_party/devtools git-subtree-split: 0d4095e47ca0e972e04efecf7772a8d12b60c665 * [XB1] Fix missing data for YouTubeTV (#1619) b/299524777 Change-Id: Iec9da5b0417b15385ec338943826dce05045bbad * Remove debug info from non-production CI builds (#1621) b/301163476 Remove "-g" for devel, debug CI builds - this helps reduce binary sizes on CI while not affecting debug info locally. Add "-gline-tables-only" for older windows platforms to get debuggable info locally and in production. * Filter intermittent blackbox test cases (#1487) b/291648592 * [media] Support string parameter in h5vcc::Settings (#1602) 1. Allow string input in H5vccSettings::Set. 2. Rename DisableMediaCodec to MediaCodecBlockList. 3. Block only the codecs in the list based on string matching. 4. MediaCodecBlockList blocks only string input separated by semicolon. If it is empty string, it allows all codecs. Examples are: // "av01": block only av1 codec // "avc1;avc3": block only h264 codec // "vp09;vp9": block only vp9 codec // "": allow all codecs b/300950119 * [XB1] Add backup version of win sdk (#1626) Adds check to see if the newer version of the win sdk is available before attempting to run makeappx and signtool, then falls back to 10.0.22000.0 if 10.0.22621.0 isn't found. b/299672207 Change-Id: I2e9ed373a940c30367aa095ff2a254ec5232dd83 * Add SetTimeZone API as a starboard extension (#1615) In order to test SbTimeZoneGetCurrent(), we need to set a time zone first. Here we add a new time zone API as a starboard extension to set time zone. We start with Linux implementation. Will have follow up PR to add implementations for all first party platforms. This will help catch the issue if a platform forget to implement SbTimeZoneGetCurrent() which always return 0. b/300108997 * [android] Add SB version guards (#1607) b/284140486 * Create MUSL specific-rename of finalize and atexit (#1588) These functions are given alternative signatures to avoid symbol collision during linking of modular-toolchain versions of the NX platform. During build, we will pass these defines via the toolchain definition to switch the names over as desired. b/246855300 * [Watchdog] Increase max ping count and length. (#1613) Increase max ping count from 20 to 60 and max ping length from 128 to 1024. b/301313509 * Publish DEPS for Chromium 48.0.2564.116 git-subtree-dir: third_party/harfbuzz-ng git-subtree-split: ba6eb95383b3c41f6b91ce448bdc2bd3e39e1b8b * Increase the timeout for XB1 Net Args service (#1634) b/299672207 * Publish DEPS for Chromium 54.0.2840.101 git-subtree-dir: third_party/jinja2 git-subtree-split: 80c41737f982b17b0c5e7c9cb05dfbfde366be15 * [XB1] Fix DX memory leak while suspend/resume (#1475) b/298967828 Change-Id: Ibbf739aac23401622b2751a0f0f3af3f169457db * Add SetTimeZone API for Raspi (#1633) b/300108997 * [android] Avoid using uninitialized drm system (#1557) b/299150189 * Add missing cstdint includes (#1643) * [XB1] Refactor test retry loop to rerun net_args (#1647) b/299672207 Change-Id: Ic90a8805fa9bc6ec7a99ffe55c318f44b82f85cb * Update games-activity to version 2.0.2. (#1614) This updates games-activity from version 1.2.2. to version 2.0.2. b/302378452 * Add platform RDK to launcher framework (#1547) Added launcher infrastructure for AH212 RDK (v5) as independent RDK platform. b/293172465 * Enable platform-specific sources to compile loader (#1652) The loader app (for modular toolchain builds) currently only relies on starboard_loader.cc as the source. For NX, we require additional sources, and those can be provided by setting the value of the newly added variable extra_platform_loader_sources in the configuration.gni file for that platform. b/246855300 * Cleanup video_stream_ & audio_stream_ after demuxer_ stops (#1651) Native crash due to fault address of video_stream_, cleanup video_stream_ & audio_stream_ after demuxer_ stops. b/301284907 * Comment on cherry pick PR on failure (#524) b/301453749 * Fix expressions * Revert "Fix expressions" This reverts commit 4d01e44. * Fix expressions 2 * REMO * REMOVE_ME remove checks * Fix cp command --------- Co-authored-by: Brian Ting <[email protected]> Co-authored-by: Liviu Rau <[email protected]> Co-authored-by: Dana Dahlstrom <[email protected]> Co-authored-by: Tyler Holcombe <[email protected]> Co-authored-by: Niranjan Yardi <[email protected]> Co-authored-by: Max Zhang <[email protected]> Co-authored-by: Bo-Rong Chen <[email protected]> Co-authored-by: Sherry Zhou <[email protected]> Co-authored-by: Jason <[email protected]> Co-authored-by: Arjun Menon <[email protected]> Co-authored-by: chrome-tpm <[email protected]> Co-authored-by: chrome-cron <[email protected]> Co-authored-by: victorpasoshnikov <[email protected]> Co-authored-by: Andrew Savage <[email protected]> Co-authored-by: Jelle Foks <[email protected]>
TyHolc
pushed a commit
to TyHolc/cobalt_sandbox
that referenced
this pull request
Jan 24, 2024
|frames_| might be accessed from different threads. It would lead to unexpected behaviors without thread safe guard. b/280825438
kaidokert
pushed a commit
to kaidokert/cobalt_sandbox
that referenced
this pull request
Mar 5, 2024
…ube#544) |frames_| might be accessed from different threads. It would lead to unexpected behaviors without thread safe guard. b/280825438 (cherry picked from commit de467c6) Co-authored-by: Jason <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b/301453749