Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment on cherry pick PR on failure #527

Merged
merged 1 commit into from
Sep 29, 2023
Merged

Comment on cherry pick PR on failure #527

merged 1 commit into from
Sep 29, 2023

Conversation

oxve
Copy link
Collaborator

@oxve oxve commented Sep 29, 2023

b/301453749

@oxve oxve added cp-23.lts.1+ Cherry Pick to the 23.lts.1+ branch cp-22.lts.1+ Cherry Pick to the 22.lts.1+ branch cp-21.lts.1+ Cherry Pick to the 21.lts.1+ branch cp-24.lts.1+ labels Sep 29, 2023
@oxve oxve merged commit 73a4d2d into main Sep 29, 2023
334 of 335 checks passed
@oxve oxve deleted the oxv/cp-change-2 branch September 29, 2023 01:17
@cobalt-github-releaser-bot cobalt-github-releaser-bot mentioned this pull request Sep 29, 2023
Closed
cobalt-github-releaser-bot pushed a commit that referenced this pull request Sep 29, 2023
@oxve @anonymous1-me
Comment on cherry pick PR on failure (#527)
2ffa92c 
b/301453749

(cherry picked from commit 73a4d2d)
kaidokert pushed a commit to kaidokert/cobalt_sandbox that referenced this pull request Mar 5, 2024
@cobalt-github-releaser-bot @jellefoks
Cherry pick PR youtube#514: Be very precise about proper thread shutd…
b087f12 
…owns. (youtube#527)

Use |DestructionObserver| and TaskRunner::WaitForFence to be really
precise about finishing all posted (non-delayed) tasks, ending with
|WillDestroyCurrentMessageLoop| as the final task on the thread to
ensure that threads properly shutdown for LocalStorageDatabase,
NetworkModule, PersistentSettings, SaveGameThread, and web::Agent

For example, |DeleteSoon| that was used in NetworkModule posts a task,
but was not guaranteed to be run when the thread shuts down.

b/284222421

(cherry picked from commit 6bb8fc1)

Co-authored-by: Jelle Foks <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cp-21.lts.1+ Cherry Pick to the 21.lts.1+ branch cp-22.lts.1+ Cherry Pick to the 22.lts.1+ branch cp-23.lts.1+ Cherry Pick to the 23.lts.1+ branch cp-24.lts.1+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@oxve