Add content to test_file #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Datadog ReportBranch report: ✅ |
kaidokert
pushed a commit
to kaidokert/cobalt_sandbox
that referenced
this pull request
Dec 8, 2023
* First implementation of Cobalt Telemetry core logic, see go/cobalt-telemetry. This PR implements Cobalt versions of all the core metrics control classes supported by //components/metrics. A H5vcc interface is added to facilitate a callback mechanism in Javascript to intercept metric's payloads. For now, only UMA is supported. UKM is explicitly disabled everywhere as is anything related to Chromium experiments (i.e., Field Trials). b/280094891 Change-Id: I1f6da00b9bb269f5597c4b6b329262fc45dd0908
kaidokert
pushed a commit
to kaidokert/cobalt_sandbox
that referenced
this pull request
Dec 8, 2023
These protos were added in th PR youtube#551 for the first introduction of Cobalt Telemetry. They are currently unused in Cobalt and removing them seems to reduce the binary size significantly (per bloaty analysis). Protos removed: omnibox_event.proto, sampled_profile.proto, memory_leak.proto. b/290819695 Change-Id: I350742ea55621b29fa3d565618098791f666c141
kaidokert
pushed a commit
to kaidokert/cobalt_sandbox
that referenced
this pull request
Mar 5, 2024
…core logic (#729) * First implementation of Cobalt Telemetry core logic, see go/cobalt-telemetry. This PR implements Cobalt versions of all the core metrics control classes supported by //components/metrics. A H5vcc interface is added to facilitate a callback mechanism in Javascript to intercept metric's payloads. For now, only UMA is supported. UKM is explicitly disabled everywhere as is anything related to Chromium experiments (i.e., Field Trials). b/280094891 Change-Id: I1f6da00b9bb269f5597c4b6b329262fc45dd0908 (cherry picked from commit 73f2621) Co-authored-by: Joel Martinez <[email protected]>
kaidokert
pushed a commit
to kaidokert/cobalt_sandbox
that referenced
this pull request
Mar 5, 2024
…ary size increase (#1029) Refer to the original PR: youtube/cobalt#1025 These protos were added in th PR youtube#551 for the first introduction of Cobalt Telemetry. They are currently unused in Cobalt and removing them seems to reduce the binary size significantly (per bloaty analysis). Protos removed: omnibox_event.proto, sampled_profile.proto, memory_leak.proto. b/290819695 Change-Id: I350742ea55621b29fa3d565618098791f666c141 Co-authored-by: Joel Martinez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.