Option to use main window window.history #444
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll defer to @nicksay but I think the iframe was used to get a clean copy of the web APIs that may have been mangled (accidentally or otherwise) in the global scope of the window by other libraries. |
zz22zz222
reviewed
Sep 12, 2019
| @@ -41,7 +41,8 @@ spf.config.defaults = { | |||
| 'navigate-lifetime': 24 * 60 * 60 * 1000, // 1 day session lifetime (ms). | |||
| 'reload-identifier': null, // Always a param, no '?' needed. | |||
| 'request-timeout': 0, // No request timeout. | |||
| 'url-identifier': '?spf=__type__' | |||
| 'url-identifier': '?spf=__type__', | |||
| 'use-iframe': true | |||
| }; | |||
|
|
|||
|
|
|||
zz22zz222
reviewed
Sep 12, 2019
| } | ||
| return /** @type {!HTMLIFrameElement} */ (frame); | ||
|
|
||
| return /** @type {!Window} */ (frame); |
zz22zz222
reviewed
Sep 12, 2019
| @@ -47,7 +47,7 @@ spf.main.init = function(opt_config) { | |||
| */ | |||
| spf.main.canInit_ = function() { | |||
| return !!(typeof window.history.pushState == 'function' || | |||
| spf.history.getIframe().contentWindow.history.pushState); | |||
| spf.history.getIframe().history.pushState); | |||
| }; | |||
|
|
|||
|
|
|||
zz22zz222
approved these changes
Sep 12, 2019
zz22zz222
approved these changes
Sep 12, 2019
|
no |
zz22zz222
approved these changes
Sep 12, 2019
This comment was marked as off-topic.
This comment was marked as off-topic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added an option to use window.history instead of iframe history.
This is needed by google tag manager & facebook pixel, they overload some method window.history method in order to track new change.
Without this options, these pixel are unusable with spf application
To be honest, I don't understand the reason of using an iframe 😄