Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor #33

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Refactor #33

wants to merge 14 commits into from

Conversation

yozik04
Copy link
Owner

@yozik04 yozik04 commented Aug 7, 2024

Will introduce some backward incompatible changes to improve code quality

@codecov-commenter
Copy link

codecov-commenter commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 73.36957% with 49 lines in your changes missing coverage. Please review.

Project coverage is 69.74%. Comparing base (b369988) to head (c59a256).

Files with missing lines Patch % Lines
nextion/client.py 70.96% 45 Missing ⚠️
nextion/console_scripts/upload_firmware.py 0.00% 2 Missing ⚠️
nextion/exceptions.py 90.90% 1 Missing ⚠️
nextion/protocol/nextion.py 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #33      +/-   ##
==========================================
+ Coverage   62.83%   69.74%   +6.91%     
==========================================
  Files           8        8              
  Lines         444      476      +32     
==========================================
+ Hits          279      332      +53     
+ Misses        165      144      -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants