Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add hyperxmp option #70

Merged
merged 1 commit into from
Mar 9, 2021
Merged

add hyperxmp option #70

merged 1 commit into from
Mar 9, 2021

Conversation

TeXhackse
Copy link
Contributor

As described in #69 this PR adds the hyperxmp boolean option, which is initialized to true. The default behaviour won't change, except if pdfx has been loaded before doclicense.

An additional option to disable/enable the automatic setting of the metadata is not necessary, I added a hint to the corresponding warning, that one would have to manually adjust this. The \hypersetup variant is not compatible to pdfx as is requests an xmdata-file.

I was a bit confused if I should already add the sty-file but since you seem to be tracking this with eery commit, I did as well.

ypid added a commit that referenced this pull request Mar 9, 2021
@ypid ypid merged commit 1a4e868 into ypid:master Mar 9, 2021
@ypid ypid added the bug label Mar 9, 2021
@ypid
Copy link
Owner

ypid commented Mar 9, 2021

Thanks, merged.

I was a bit confused if I should already add the sty-file but since you seem to be tracking this with eery commit, I did as well.

Thanks for the hint. I reconsidered now and dropped the sty files from being tracked by git.

@zhtaihao
Copy link

@TeXhackse Thank you for drafting this PR, seems like a great addition.

@ypid Any estimate on when we can expect this update to be on CTAN/Sharelatex?

@ypid
Copy link
Owner

ypid commented Mar 10, 2021

I usually wait a few weeks before I release new features. As now 3 people are involved in this feature, there is some level of review so what do you say when I release it on Friday 2021-03-12?

@ypid
Copy link
Owner

ypid commented Mar 17, 2021

It has been released on Monday, ref: https://ctan.org/ctan-ann/id/[email protected]. I took a few hours on Saturday to work on the package a bit before releasing it. With the release, can #69 be closed?

@TeXhackse
Copy link
Contributor Author

Yup, @ypid. thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants