Add support annotations for pixel dimension and color int #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yqritc can you take a look at this? It's fairly straightforward and really helpful. |
|
Any time for this small, yet very useful change? |
|
@yqritc Hello there, can you review and merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today I spent half an hour debugging why nothing shows in my recycler.
I called
size(R.dimen.home_item_spacing)instead ofsizeResId(R.dimen.home_item_spacing)which resulted in a huge divider spacing.These changes will make lint warn about that problem and some related problems (margins an color ints).