Skip to content

Commit

Permalink
Check native-tests.json/virtual-threads-tests.json in CI build
Browse files Browse the repository at this point in the history
  • Loading branch information
yrodiere committed Nov 29, 2023
1 parent e4f8d1e commit 091f241
Show file tree
Hide file tree
Showing 2 changed files with 45 additions and 0 deletions.
41 changes: 41 additions & 0 deletions .github/verify-tests-json.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
#!/bin/bash

# Purpose: Verify that a JSON file such as native-tests.json only contains valid references in its "test-modules" fields
# Note: This script is only for CI and does therefore not aim to be compatible with BSD/macOS.

set -e -u -o pipefail
shopt -s failglob

# path of this shell script
PRG_PATH=$( cd "$(dirname "$0")" ; pwd -P )

if (( $# != 2 ))
then
echo 'Invalid parameters'
echo 'Usage: $0 <path from .github/ to json file to check> <path from repository root to integration test directory>'
exit 1
fi

JSON_PATH="${PRG_PATH}/$1"
IT_DIR_PATH="$2"

echo "Checking JSON file $JSON_PATH against modules in directory $IT_DIR_PATH"

INVALID_REFS=($(
# Print unmatched names from the JSON file
# Input 1: List all test modules from the JSON file, one per line, trimmed, sorted
# Input 2: List all Maven modules, one per line, sorted
join -v 1 \
<(jq -r '.include[] | ."test-modules"' ${PRG_PATH}/$1 | tr ',' $'\n' | sed 's|^\s*||;s|\s*$||;' | grep -v '^$' | sort) \
<(find "$IT_DIR_PATH" -mindepth 2 -name pom.xml -exec realpath --relative-to "$IT_DIR_PATH" '{}' \; | xargs -d $'\n' -n 1 dirname | sort)
))

if [[ ${#INVALID_REFS[@]} = 0 ]]
then
echo "$JSON_PATH is valid when checked against $IT_DIR_PATH"
exit 0
else
echo "$JSON_PATH is invalid when checked against $IT_DIR_PATH"
echo "'test-modules' that cannot be resolved as paths to Maven modules relative to $IT_DIR_PATH: ${INVALID_REFS[*]}"
exit 1
fi
4 changes: 4 additions & 0 deletions .github/workflows/ci-actions-incremental.yml
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,10 @@ jobs:
path: ~/.m2/repository
# refresh cache every week to avoid unlimited growth
key: ${{ steps.m2-cache-key.outputs.key }}
- name: Verify native-tests.json
run: ./verify-tests-json.sh native-tests.json integration-tests/
- name: Verify virtual-threads-tests.json
run: ./verify-tests-json.sh virtual-threads-tests.json integration-tests/virtual-threads/
- name: Build
run: |
./mvnw -T1C $COMMON_MAVEN_ARGS -DskipTests -DskipITs -DskipDocs -Dinvoker.skip -Dno-format -Dtcks -Prelocations clean install
Expand Down

0 comments on commit 091f241

Please sign in to comment.