Non-visible views and OnScreenSwitchListener #15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
horizontalpager
had a child view that had visibility set toView.GONE
it would correctly not callonLayout
for it, but would incorrectly still take it into account in other calculations. This behavior would cause an empty black screen to appear at the end. My patch fixes this by not counting children withView.GONE
set.My patch also adds
onScreenSelected
toOnScreenSwitchListener
to notify user about a new screen but before the animation.