create action to prepare releases #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yshavit
commented
Mar 2, 2025
Comment on lines
+90
to
+104
| - name: Dev Cargo.toml | ||
| run: | | ||
| sed -i 's/^version = ".*"/version = "${{ env.NEXT_DEV_VERSION }}"/' Cargo.toml | ||
| cargo metadata >/dev/null | ||
|
|
||
| - name: Dev Commit | ||
| run: | | ||
| set -euo pipefail | ||
| git checkout -b "release-$RELEASE_VERSION-post" | ||
| git commit -am "bump version to $NEXT_DEV_VERSION" | ||
| git push --set-upstream origin "release-$RELEASE_VERSION-post" | ||
|
|
||
| - name: Dev PR | ||
| run: | | ||
| gh pr create --title "Prepare v${NEXT_DEV_VERSION}" --body "Bump version to $NEXT_DEV_VERSION" --base "release-$RELEASE_VERSION" |
There was a problem hiding this comment.
The "Dev *" steps don't quite work: the squash commit of the release version causes them to conflict once they change to target main.
Still, it's good enough for now.
| - name: Create new release | ||
| id: create_release | ||
| run: | | ||
| release_url="$(gh release create "$TAG_NAME" --draft --title "$TAG_NAME" --generate-notes --target "release-$RELEASE_VERSION")" |
There was a problem hiding this comment.
Targeting the release commit doesn't quite work: we really want to target the version once it hits main.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.