Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap all server actions in Sentry.withServerActionInstrumentation #150

Merged
merged 4 commits into from
Sep 12, 2024

Conversation

markspolakovs
Copy link
Member

Sentry doesn't do it automatically (getsentry/sentry-javascript#9458)

@markspolakovs
Copy link
Member Author

You probably want to review this with "hide whitespace changes" selected
image

@jenkins-ystv
Copy link

jenkins-ystv bot commented Sep 11, 2024

Deployed a preview of this PR to https://pr-150-internal.dev.ystv.co.uk

@markspolakovs
Copy link
Member Author

Clicked around the PR preview, most key functions work as they used to.

@markspolakovs
Copy link
Member Author

And I can see the data coming through in Sentry:
image
Unfortunately it doesn't associate it with the user, need to work out if there's a good way of doing that.

Copy link
Member

@archessmn archessmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming this is just for tracking these actions in sentry? Seems legit to me but perhaps having some docs about how all of the Sentry stuff works would be good to have in the future (not now, happy for this to be merged).

@markspolakovs
Copy link
Member Author

I'm assuming this is just for tracking these actions in sentry? Seems legit to me but perhaps having some docs about how all of the Sentry stuff works would be good to have in the future (not now, happy for this to be merged).

And getting meaningful error reports from them.

@markspolakovs markspolakovs merged commit f8d23d2 into main Sep 12, 2024
3 checks passed
@markspolakovs markspolakovs deleted the mp/server-action-instrumentation branch September 12, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants