Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#CheckWithTech: Error handling and correct perms check #153

Merged
merged 2 commits into from
Sep 12, 2024
Merged

#CheckWithTech: Error handling and correct perms check #153

merged 2 commits into from
Sep 12, 2024

Conversation

markspolakovs
Copy link
Member

@markspolakovs markspolakovs commented Sep 12, 2024 •
edited
Loading

This fixes two issues with the #CheckWithTech form:

  • The permissions check was using canManage, when it should have been canManageAnySignUpSheet (to allow any producer to submit it)
    • Also change the prompt display check to canManageAnySignUpSheet
  • There was no error handling (oops)

@jenkins-ystv
Copy link

jenkins-ystv bot commented Sep 12, 2024

Deployed a preview of this PR to https://pr-153-internal.dev.ystv.co.uk

archessmn
archessmn approved these changes Sep 12, 2024
View reviewed changes
Copy link
Member

@archessmn archessmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@markspolakovs markspolakovs merged commit 2451d5f into main Sep 12, 2024
3 checks passed
@markspolakovs markspolakovs deleted the mp/fix-checkwithtech-perms-and-error-handling branch September 12, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@archessmn archessmn archessmn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markspolakovs @archessmn