BUG: fix ds.all_data() for spherical AMReX datasets #5025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yut23
added a commit
to yut23/website
that referenced
this pull request
Oct 10, 2024
|
For future reference, the datasets are registered at yt-project/website#129 |
|
very nice. Let me add this to the 4.4.0 milestone in case we can squeeze it in before the release is unblocked. |
`ds.index.level_dds` was being overwritten in `_parse_index()`, which breaks the `all_data()` region selector. This commit instead updates `domain_right_edge` in `_parse_header_file()`, like we do for cylindrical datasets.
yut23
force-pushed
the
amrex-add-2d-spherical
branch
from
01b2ffa to
5b6763e
Compare
|
I've tested this an it fixes the problem we were having with 2D r-theta |
zingale
approved these changes
Jan 2, 2025
|
@yt-fido test this please |
|
What's the status of this PR? The failing tests are just from the new datasets not being on the website yet. |
|
@yt-fido test this please |
Xarthisius
added a commit
to yt-project/website
that referenced
this pull request
Feb 11, 2025
Add datasets needed for testing yt-project/yt#5025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
ds.index.level_ddswas being overwritten in_parse_index(), which breaks theall_data()region selector. This PR instead updatesdomain_right_edgein_parse_header_file(), like we do for cylindrical datasets.PR Checklist