Skip to content

Commit

Permalink
nolint for "k8s.io/utils/pointer" is deprecated
Browse files Browse the repository at this point in the history
  • Loading branch information
l0kix2 committed Jun 27, 2024
1 parent 0b71a88 commit 9cc869c
Show file tree
Hide file tree
Showing 11 changed files with 17 additions and 14 deletions.
2 changes: 1 addition & 1 deletion api/v1/test_helpers.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import (
corev1 "k8s.io/api/core/v1"
"k8s.io/apimachinery/pkg/api/resource"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
ptr "k8s.io/utils/pointer"
ptr "k8s.io/utils/pointer" //nolint:staticcheck

Check failure on line 11 in api/v1/test_helpers.go

View workflow job for this annotation

GitHub Actions / Run checks

directive `//nolint:staticcheck` is unused for linter "staticcheck" (nolintlint)
)

const (
Expand Down
2 changes: 1 addition & 1 deletion api/v1/ytsaurus_webhook.go
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ import (
"k8s.io/apimachinery/pkg/runtime/schema"
"k8s.io/apimachinery/pkg/util/validation/field"
"k8s.io/apimachinery/pkg/util/yaml"
ptr "k8s.io/utils/pointer"
ptr "k8s.io/utils/pointer" //nolint:staticcheck

Check failure on line 30 in api/v1/ytsaurus_webhook.go

View workflow job for this annotation

GitHub Actions / Run checks

directive `//nolint:staticcheck` is unused for linter "staticcheck" (nolintlint)
ctrl "sigs.k8s.io/controller-runtime"
logf "sigs.k8s.io/controller-runtime/pkg/log"
"sigs.k8s.io/controller-runtime/pkg/webhook"
Expand Down
2 changes: 1 addition & 1 deletion controllers/remoteexecnodes_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import (
appsv1 "k8s.io/api/apps/v1"
corev1 "k8s.io/api/core/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
ptr "k8s.io/utils/pointer"
ptr "k8s.io/utils/pointer" //nolint:staticcheck

Check failure on line 13 in controllers/remoteexecnodes_test.go

View workflow job for this annotation

GitHub Actions / Run checks

directive `//nolint:staticcheck` is unused for linter "staticcheck" (nolintlint)
ctrl "sigs.k8s.io/controller-runtime"
"sigs.k8s.io/controller-runtime/pkg/client"

Expand Down
2 changes: 1 addition & 1 deletion pkg/components/exec_node_base.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import (
"path"

corev1 "k8s.io/api/core/v1"
ptr "k8s.io/utils/pointer"
ptr "k8s.io/utils/pointer" //nolint:staticcheck

Check failure on line 9 in pkg/components/exec_node_base.go

View workflow job for this annotation

GitHub Actions / Run checks

directive `//nolint:staticcheck` is unused for linter "staticcheck" (nolintlint)

ytv1 "github.com/ytsaurus/yt-k8s-operator/api/v1"

Expand Down
8 changes: 5 additions & 3 deletions pkg/components/microservice.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,17 @@ package components
import (
"context"

ptr "k8s.io/utils/pointer" //nolint:staticcheck

Check failure on line 6 in pkg/components/microservice.go

View workflow job for this annotation

GitHub Actions / Run checks

directive `//nolint:staticcheck` is unused for linter "staticcheck" (nolintlint)

ytv1 "github.com/ytsaurus/yt-k8s-operator/api/v1"
ptr "k8s.io/utils/pointer"

appsv1 "k8s.io/api/apps/v1"
corev1 "k8s.io/api/core/v1"

"github.com/ytsaurus/yt-k8s-operator/pkg/apiproxy"
"github.com/ytsaurus/yt-k8s-operator/pkg/labeller"
"github.com/ytsaurus/yt-k8s-operator/pkg/resources"
"github.com/ytsaurus/yt-k8s-operator/pkg/ytconfig"
appsv1 "k8s.io/api/apps/v1"
corev1 "k8s.io/api/core/v1"
)

// microservice manages common resources of YTsaurus service component
Expand Down
2 changes: 1 addition & 1 deletion pkg/components/server.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import (
"path"

"k8s.io/apimachinery/pkg/util/intstr"
ptr "k8s.io/utils/pointer"
ptr "k8s.io/utils/pointer" //nolint:staticcheck

Check failure on line 9 in pkg/components/server.go

View workflow job for this annotation

GitHub Actions / Run checks

directive `//nolint:staticcheck` is unused for linter "staticcheck" (nolintlint)

appsv1 "k8s.io/api/apps/v1"
corev1 "k8s.io/api/core/v1"
Expand Down
2 changes: 1 addition & 1 deletion pkg/components/ytsaurus_client.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import (
"go.ytsaurus.tech/yt/go/yt"
"go.ytsaurus.tech/yt/go/yt/ythttp"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
ptr "k8s.io/utils/pointer"
ptr "k8s.io/utils/pointer" //nolint:staticcheck

Check failure on line 14 in pkg/components/ytsaurus_client.go

View workflow job for this annotation

GitHub Actions / Run checks

directive `//nolint:staticcheck` is unused for linter "staticcheck" (nolintlint)

ytv1 "github.com/ytsaurus/yt-k8s-operator/api/v1"
"github.com/ytsaurus/yt-k8s-operator/pkg/apiproxy"
Expand Down
2 changes: 1 addition & 1 deletion pkg/testutil/builders.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ package testutil
import (
corev1 "k8s.io/api/core/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
ptr "k8s.io/utils/pointer"
ptr "k8s.io/utils/pointer" //nolint:staticcheck

Check failure on line 6 in pkg/testutil/builders.go

View workflow job for this annotation

GitHub Actions / Run checks

directive `//nolint:staticcheck` is unused for linter "staticcheck" (nolintlint)

ytv1 "github.com/ytsaurus/yt-k8s-operator/api/v1"
"github.com/ytsaurus/yt-k8s-operator/pkg/consts"
Expand Down
2 changes: 1 addition & 1 deletion pkg/ytconfig/generator.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import (
"path"

corev1 "k8s.io/api/core/v1"
ptr "k8s.io/utils/pointer"
ptr "k8s.io/utils/pointer" //nolint:staticcheck

Check failure on line 8 in pkg/ytconfig/generator.go

View workflow job for this annotation

GitHub Actions / Run checks

directive `//nolint:staticcheck` is unused for linter "staticcheck" (nolintlint)

"go.ytsaurus.tech/yt/go/yson"

Expand Down
5 changes: 3 additions & 2 deletions pkg/ytconfig/node.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,14 @@ import (

"go.ytsaurus.tech/yt/go/yson"

ptr "k8s.io/utils/pointer"
ptr "k8s.io/utils/pointer" //nolint:staticcheck

Check failure on line 11 in pkg/ytconfig/node.go

View workflow job for this annotation

GitHub Actions / Run checks

directive `//nolint:staticcheck` is unused for linter "staticcheck" (nolintlint)

"k8s.io/apimachinery/pkg/api/resource"

corev1 "k8s.io/api/core/v1"

ytv1 "github.com/ytsaurus/yt-k8s-operator/api/v1"
"github.com/ytsaurus/yt-k8s-operator/pkg/consts"
corev1 "k8s.io/api/core/v1"
)

type NodeFlavor string
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/suite_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ import (
"testing"
"time"

ptr "k8s.io/utils/pointer"
ptr "k8s.io/utils/pointer" //nolint:staticcheck

. "github.com/onsi/ginkgo/v2"
. "github.com/onsi/gomega"
Expand Down

0 comments on commit 9cc869c

Please sign in to comment.