Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invent compatibility check with ytsaurus server for ytop #367

Open
l0kix2 opened this issue Oct 15, 2024 · 1 comment
Open

Invent compatibility check with ytsaurus server for ytop #367

l0kix2 opened this issue Oct 15, 2024 · 1 comment

Comments

@l0kix2
Copy link
Collaborator

l0kix2 commented Oct 15, 2024

We need some way to store supported yt versions in ytop code and some way of checking that image used in spec has correct version.
Preferably this should be done as soon as possible or at least before the cluster update in checkPossibility code.

@l0kix2
Copy link
Collaborator Author

l0kix2 commented Jan 21, 2025

  1. If we try to fetch major version from user image:tag string — we can
    a) use it in validation webhook which is nice
    b) easy use it in reconilation flow to add checks which require version
    The problems here are
    a) we don't have contract for users to have images with version specified in tag and not sure if it is a good way (maybe compromise can be fetching version by default, but users can disable it with losing respective checks)
    b) maybe we need more fields like reign or smth which are not in image:tag string

  2. If we try to run ytsaurus binary in job before update and fetch results from it — we need to invent a way to do that, because we don't have such jobs currently. Maybe configmap can be updated from job, maybe structured job logs can be used or some other solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

1 participant