added discovery_server section into master config #169
+17
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l0kix2
approved these changes
Mar 19, 2024
|
Let's add a check to one of our e2e tests that checks that the directory |
achulkov2
requested changes
Mar 19, 2024
| @@ -37,6 +41,7 @@ type MasterServer struct { | |||
| CypressManager CypressManager `yson:"cypress_manager"` | |||
| PrimaryMaster MasterCell `yson:"primary_master"` | |||
| SecondaryMasters []MasterCell `yson:"secondary_masters"` | |||
| DiscoveryServers DiscoveryServers `yson:"discovery_server"` | |||
There was a problem hiding this comment.
Let's keep the naming consistent with the yson config name. So DiscoveryServer without the plural.
|
@qurname2 it looks like just small fixes left here. Maybe you will finish it some time (obviously not urgent if it already hangs for too long) or close if already not needed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to resolve #63