allow to customize readiness probe path and configure additional component ports #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l0kix2
requested changes
Apr 24, 2024
pkg/components/server.go
Outdated
|
|
||
| componentContainerPorts: []corev1.ContainerPort{ | ||
| { | ||
| Name: consts.YTMonitoringContainerPortName, |
There was a problem hiding this comment.
Suppose we should mention this backward incompatibility rename in release notes after merge.
|
@l0kix2 I took all of your comments into account, could you take another look? |
l0kix2
approved these changes
Apr 25, 2024
nope. well, except for the fact that sts removal is required to changes get applied to pod manifests. and monitoring port rename which was already mentioned above |
leo-astorsky
pushed a commit
to leo-astorsky/yt-k8s-operator
that referenced
this pull request
Aug 13, 2024
…onent ports (ytsaurus#251) * allow to customize readiness probe path * linting * fix * stage * stage * refactor * simplify
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.