SetHostnameAsFQDN option is added to all components. Default is true #302
Conversation
| if diff := cmp.Compare(slices.Index(statusOrder, a.Status), slices.Index(statusOrder, b.Status)); diff != 0 { | ||
| return diff | ||
| } | ||
| return a.LastTransitionTime.Compare(b.LastTransitionTime.Time) |
There was a problem hiding this comment.
Our linter test didn't catch that last time? =/
There was a problem hiding this comment.
shouln't diff be gone after 6a6f343 ?
Maybe need to rebase
|
it seems the added options isn't used in podtemplate generation. it still has the hardcoded true value there |
|
I suggest we use spec default true for simplicity and check for the diff when will update ytop. If there is a diff — will mention in the release notes |
lets just use the value from the spec and set |
…stanceSpec in one place in server.go
|
Fix #295 |
…tsaurus#302) * SetHostnameAsFQDN option is added to all components. Default is true * SetHostnameAsFQDN is true by default and the value is getting from instanceSpec in one place in server.go * forgot lint-generated
No description provided.