Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Operator should detect configOverrides updates #314

Merged
merged 4 commits into from
Jul 23, 2024
Merged

Conversation

l0kix2
Copy link
Collaborator

@l0kix2 l0kix2 commented Jul 23, 2024

Fix #291

Implemented a test that reproduced an issue with the operator not being triggered by config overrides update. Fixed the issue as recommended in the kubebuilder docs https://book.kubebuilder.io/reference/watching-resources/externally-managed.

@l0kix2 l0kix2 marked this pull request as draft July 23, 2024 11:22
@l0kix2 l0kix2 changed the title #291 Repro test Operator should detect configOverrides updates Jul 23, 2024
@l0kix2 l0kix2 marked this pull request as ready for review July 23, 2024 13:14
@l0kix2 l0kix2 requested a review from Krock21 July 23, 2024 13:14
@l0kix2 l0kix2 merged commit b360ffd into main Jul 23, 2024
5 checks passed
@l0kix2 l0kix2 deleted the l0kix2/config_overrides branch July 23, 2024 13:21
leo-astorsky pushed a commit to leo-astorsky/yt-k8s-operator that referenced this pull request Aug 13, 2024
* ytsaurus#291 Repro test

* fix lint

* Implement configOverrides reconciliation

* Fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Operator doesn't detect config overrides apply
2 participants