-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multiple update selectors #383
Open
wilwell
wants to merge
8
commits into
main
Choose a base branch
from
wilwell/multiple-update-selectors
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3be85ec
to
e9c2100
Compare
l0kix2
reviewed
Nov 8, 2024
ae5affa
to
fae9001
Compare
a6175c8
to
06fd1a8
Compare
Please rebase on the main branch since #387 is merged — which have couple of new stages in the flows |
l0kix2
requested changes
Dec 18, 2024
39016b9
to
683a5b9
Compare
683a5b9
to
e9c82c1
Compare
l0kix2
approved these changes
Feb 5, 2025
I've added e2e test. Please review it. We have two unanswered questions
|
18967d4
to
e679582
Compare
koct9i
reviewed
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the functionality of multiple update selectors.
Instead of outdated
UpdateSelector
users can useUpdatePlan
with list ofComponentUpdateSelector
inside it.Each
ComponentUpdateSelector
can either containComponentClass
orComponent
.ComponentClass
containsEverything, Nothing, Stateless
groups of component. If operator seesNothing
component class, then all updates are forbidden.Component
could hasType
andName
fields. IfName
is not set then all components with thisType
will be updated.Also I've added webhook check, that empty
UpdatePlan
is forbidden. In case ifUpdatePlan
is not set operator uses values of deprecatedUpdateSelector
for smoother transition between versions.