Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests for PRs #72

Closed
wants to merge 6 commits into from
Closed

Run tests for PRs #72

wants to merge 6 commits into from

Conversation

l0kix2
Copy link
Collaborator

@l0kix2 l0kix2 commented Dec 8, 2023

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Separate workflow for running tests for PRs — runs for our repo and skipped for forks (they don't have required creds anyway) so we stop main branch e2e tests from breaking at least by internal contributors' PRs

Copy link

robot-magpie bot commented Dec 8, 2023

✅ All contributors are covered under a CLA with Yandex

See CONTRIBUTING.md for more info about Yandex Contributor License Agreement.


The following contributors were found:
f054539 Author: @l0kix2 (s****[email protected])

(Only the first commit for a unique contributor is listed)

@l0kix2
Copy link
Collaborator Author

l0kix2 commented Dec 8, 2023

Example of external PR from fork with skipped tests #73

@nadya002 nadya002 requested a review from savnadya December 11, 2023 06:45
with:
fetch-depth: 0

check:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move this job to a several file as in ytsaurus repo: https://github.com/ytsaurus/ytsaurus/blob/main/.github/workflows/cpp.yaml#L126

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean to reuse the step to avoid duplication, correct?

Copy link

robot-magpie bot commented Dec 18, 2023

✅ All contributors are covered under a CLA with Yandex

See CONTRIBUTING.md for more info about Yandex Contributor License Agreement.


The following contributors were found:
f054539 Author: @l0kix2 (s****[email protected])

(Only the first commit for a unique contributor is listed)

1 similar comment
Copy link

robot-magpie bot commented Dec 18, 2023

✅ All contributors are covered under a CLA with Yandex

See CONTRIBUTING.md for more info about Yandex Contributor License Agreement.


The following contributors were found:
f054539 Author: @l0kix2 (s****[email protected])

(Only the first commit for a unique contributor is listed)

Copy link

robot-magpie bot commented Dec 19, 2023

✅ All contributors are covered under a CLA with Yandex

See CONTRIBUTING.md for more info about Yandex Contributor License Agreement.


The following contributors were found:
f054539 Author: @l0kix2 (s****[email protected])

(Only the first commit for a unique contributor is listed)

2 similar comments
Copy link

robot-magpie bot commented Dec 19, 2023

✅ All contributors are covered under a CLA with Yandex

See CONTRIBUTING.md for more info about Yandex Contributor License Agreement.


The following contributors were found:
f054539 Author: @l0kix2 (s****[email protected])

(Only the first commit for a unique contributor is listed)

Copy link

robot-magpie bot commented Dec 19, 2023

✅ All contributors are covered under a CLA with Yandex

See CONTRIBUTING.md for more info about Yandex Contributor License Agreement.


The following contributors were found:
f054539 Author: @l0kix2 (s****[email protected])

(Only the first commit for a unique contributor is listed)

@savnadya
Copy link
Collaborator

Shipped!

Copy link

robot-magpie bot commented Dec 19, 2023

@savnadya has imported your pull request. If you are a Yandex employee, you can view this diff.

@l0kix2 l0kix2 force-pushed the sibirev/test_for_prs branch from d96349b to 287b41d Compare December 19, 2023 14:26
Copy link

robot-magpie bot commented Dec 19, 2023

✅ All contributors are covered under a CLA with Yandex

See CONTRIBUTING.md for more info about Yandex Contributor License Agreement.


The following contributors were found:
9462531 Author: @l0kix2 (s****[email protected])

(Only the first commit for a unique contributor is listed)

@savnadya
Copy link
Collaborator

Shipped!

Copy link

robot-magpie bot commented Dec 19, 2023

@savnadya has imported your pull request. If you are a Yandex employee, you can view this diff.

Copy link

robot-magpie bot commented Dec 19, 2023

❌ This pull request has been discarded.

Copy link

robot-magpie bot commented Dec 19, 2023

✅ This pull request is being closed because it has been successfully merged.

@l0kix2 l0kix2 deleted the sibirev/test_for_prs branch December 20, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants