-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC-428][doc] Fix Linux yugabyted examples #26104
base: master
Are you sure you want to change the base?
[DOC-428][doc] Fix Linux yugabyted examples #26104
Conversation
✅ Deploy Preview for infallible-bardeen-164bc9 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
docs/content/preview/api/ysql/exprs/geo_partitioning_helper_functions/func_yb_is_local_table.md
Outdated
Show resolved
Hide resolved
@@ -36,20 +36,20 @@ This function is helpful while implementing [Row-level geo-partitioning](../../. | |||
```sh | |||
./bin/yugabyted start \ | |||
--base_dir=/home/yugabyte/<IP1>/yugabyte-data \ | |||
--listen=<IP1> \ | |||
--advertise_address=<IP1> \ | |||
--master_flags "placement_cloud=aws,placement_region=us-west-1,placement_zone=us-west-1c" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nmalladi These master/tserver placement flags - are they now replaced by yugabyted --cloud_location flag
@sudhanshu456 see https://docs.yugabyte.com/preview/reference/configuration/yugabyted/#create-a-multi-region-cluster
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was there any mention of a replacement for --cloud_location flag in our docs, or we just replaced it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The example is old, this would have been several versions back - pre 2.14 I'm thinking
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think docs page is being used anymore right?
As these docs are target for preview release, we should use the'-cloud_location` flag to pass the placement info.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -44,20 +44,20 @@ Do the following to create a 3-node multi-region cluster and a geo-partitioned t | |||
```sh | |||
./bin/yugabyted start \ | |||
--base_dir=/home/yugabyte/<IP1>/yugabyte-data \ | |||
--listen=<IP1> \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are making changes to replace --listen
to --advertise_address
. We should also go ahead and replace this
--master_flags "placement_cloud=aws,placement_region=us-east-2,placement_zone=us-east-2c" \
--tserver_flags "placement_cloud=aws,placement_region=us-east-2,placement_zone=us-east-2c"
with
./bin/yugabyted start \
--base_dir=/home/yugabyte/<IP2>/yugabyte-data \
--advertise_address=<IP2> \
--cloud_location=aws.us-east-2.us-east-2c \
--join=<IP1>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sudhanshu456 can you make these changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, will do
@netlify /preview/tutorials/quick-start/linux/#create-a-local-cluster