Merge pull request #84 from yujiosaka/e2e_test

E2e test
yujiosaka · Jan 19, 2018 · 10dfe10 · 10dfe10
2 parents c1ea0b2 + 52741de
commit 10dfe10
Show file tree

Hide file tree

Showing 7 changed files with 489 additions and 171 deletions.
diff --git a/lib/crawler.js b/lib/crawler.js
@@ -135,8 +135,8 @@ class Crawler {
    * @private
    */
   _handlePageEvents() {
-    this._page.on('pageerror', msg => void debugConsole(msg));
-    this._page.on('console', msg => void debugConsole(`${msg.type} ${msg.text} at ${this._options.url}`));
+    this._page.on('pageerror', text => void debugConsole(text));
+    this._page.on('console', msg => void debugConsole(`${msg.type()} ${msg.text()} at ${this._options.url}`));
     this._page.on('dialog', dialog => this._handleDialog(dialog));
   }
 
@@ -146,7 +146,7 @@ class Crawler {
    * @private
    */
   _handleDialog(dialog) {
-    debugDialog(`${dialog.type} ${dialog.message()} at ${this._options.url}`);
+    debugDialog(`${dialog.type()} ${dialog.message()} at ${this._options.url}`);
     return dialog.dismiss();
   }
 

diff --git a/package.json b/package.json
@@ -31,6 +31,7 @@
     "eslint": "4.15.0",
     "eslint-config-airbnb": "16.1.0",
     "eslint-plugin-import": "2.8.0",
+    "mime": "2.2.0",
     "mocha": "5.0.0",
     "power-assert": "1.4.4",
     "sinon": "4.1.6"

diff --git a/test/.eslintrc.js b/test/.eslintrc.js
@@ -1,5 +1,8 @@
 module.exports = {
   "extends": "../.eslintrc.js",
+  "globals": {
+    '$': true,
+  },
   "env": {
     "mocha": true,
   },