Skip to content

Commit

Permalink
Clarify Bazel 8.0 is not yet supported (google#1118) (google#1123)
Browse files Browse the repository at this point in the history
As Mozc is not compatible with Bazel 8.0 yet, let's

 * pin Bazel version to Bazel 7.4.1 in GitHub Actions.
 * clarify that Bazel 8.0 is not supported in the build instructions.

PiperOrigin-RevId: 698388242
  • Loading branch information
yukawa authored Nov 20, 2024
1 parent 38fec15 commit 2016df9
Show file tree
Hide file tree
Showing 9 changed files with 23 additions and 2 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/android.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ jobs:
- name: build
working-directory: ./src
env:
USE_BAZEL_VERSION: "7.4.1"
run: |
bazel build --config oss_android package --config release_build
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/linux.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@ jobs:
- name: bazel build
working-directory: ./src
env:
USE_BAZEL_VERSION: "7.4.1"
run: |
bazel build --config oss_linux package --config release_build
Expand Down Expand Up @@ -64,5 +66,7 @@ jobs:
- name: bazel test
working-directory: ./src
env:
USE_BAZEL_VERSION: "7.4.1"
run: |
bazel test ... --config oss_linux --build_tests_only -c dbg
8 changes: 8 additions & 0 deletions .github/workflows/macos.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,8 @@ jobs:
- name: bazel build
working-directory: ./src
env:
USE_BAZEL_VERSION: "7.4.1"
run: |
bazel build --config oss_macos package --macos_cpus=arm64 --config release_build
Expand Down Expand Up @@ -103,6 +105,8 @@ jobs:
- name: bazel build
working-directory: ./src
env:
USE_BAZEL_VERSION: "7.4.1"
run: |
bazel build --config oss_macos package --macos_cpus=x86_64 --config release_build
Expand Down Expand Up @@ -152,6 +156,8 @@ jobs:
- name: bazel build
working-directory: ./src
env:
USE_BAZEL_VERSION: "7.4.1"
run: |
bazel build --config oss_macos package --macos_cpus=x86_64,arm64 --config release_build
Expand Down Expand Up @@ -201,6 +207,8 @@ jobs:
- name: bazel test
working-directory: ./src
env:
USE_BAZEL_VERSION: "7.4.1"
run: |
bazel test ... --config oss_macos --build_tests_only -c dbg
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/windows.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,7 @@ jobs:
working-directory: .\src
env:
ANDROID_NDK_HOME: ""
USE_BAZEL_VERSION: "7.4.1"
run: |
bazel --bazelrc=windows.bazelrc build --config oss_windows --config release_build package
Expand Down
2 changes: 2 additions & 0 deletions docker/ubuntu22.04/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,8 @@ ENV PKG_CONFIG_PATH="/home/mozc_builder/work/mozc/docker/ubuntu22.04/qt6-core-pk
RUN curl -LO https://github.com/bazelbuild/bazelisk/releases/download/v1.22.0/bazelisk-linux-amd64 \
&& mv bazelisk-linux-amd64 /home/mozc_builder/bin/bazel \
&& chmod u+x /home/mozc_builder/bin/bazel
### TODO(https://github.com/google/mozc/issues/1118): Support Bazel 8.0
ENV USE_BAZEL_VERSION 7.4.1

## Set up Android SDK and NDK
ENV ANDROID_HOME /home/mozc_builder/Android/Sdk
Expand Down
2 changes: 2 additions & 0 deletions docker/ubuntu24.04/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,8 @@ WORKDIR /home/mozc_builder/work
RUN curl -LO https://github.com/bazelbuild/bazelisk/releases/download/v1.22.0/bazelisk-linux-amd64 \
&& mv bazelisk-linux-amd64 /home/mozc_builder/bin/bazel \
&& chmod u+x /home/mozc_builder/bin/bazel
### TODO(https://github.com/google/mozc/issues/1118): Support Bazel 8.0
ENV USE_BAZEL_VERSION 7.4.1

## Set up Android SDK and NDK
ENV ANDROID_HOME /home/mozc_builder/Android/Sdk
Expand Down
1 change: 1 addition & 0 deletions docs/build_mozc_in_osx.md
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ Building on Mac requires the following software.
* Xcode 13 (macOS 13 SDK) or later
* ⚠️Xcode Command Line Tools aren't sufficient.
* [Bazel](https://docs.bazel.build/versions/master/install-os-x.html) for Bazel build
* ⚠️ Bazel 8.x is not yet supported ([#1118](https://github.com/google/mozc/issues/1118))
* Python 3.9 or later with the following pip module.
* `requests`
* CMake 3.18.4 or later (to build Qt6)
Expand Down
1 change: 1 addition & 0 deletions docs/build_mozc_in_windows.md
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,7 @@ Note that you can specify `--qtdir=` option instead of `--noqt` in GYP phase sin
Additional requirements:

* [Bazel](https://bazel.build/)
* ⚠️ Bazel 8.x is not yet supported ([#1118](https://github.com/google/mozc/issues/1118))
* [MSYS2](https://github.com/msys2/msys2)

After running `build_tools/update_deps.py` and `build_tools/build_qt.py`, run the following command instead of `build_mozc.py`:
Expand Down
4 changes: 2 additions & 2 deletions src/.bazelversion
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@

7.3.0
7.4.1
# The first liine is intentionally empty to allow any Bazel versions.
# We have checked the build and tests with Bazel 7.3.0.
# We have checked the build and tests with Bazel 7.4.1.
# Remove the first line and use Bazelisk to use the confirmed version.

0 comments on commit 2016df9

Please sign in to comment.