Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST3] #5

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

[TEST3] #5

wants to merge 13 commits into from

Conversation

yuqi1129
Copy link
Owner

What changes were proposed in this pull request?

(Please outline the changes and how this PR fixes the issue.)

Why are the changes needed?

(Please clarify why the changes are needed. For instance,

  1. If you propose a new API, clarify the use case for a new API.
  2. If you fix a bug, describe the bug.)

Fix: # (issue)

Does this PR introduce any user-facing change?

(Please list the user-facing changes introduced by your change, including

  1. Change in user-facing APIs.
  2. Addition or removal of property keys.)

How was this patch tested?

(Please test your changes, and provide instructions on how to test it:

  1. If you add a feature or fix a bug, add a test to cover your changes.
  2. If you fix a flaky test, repeat it for many times to prove it works.)

yuqi1129 pushed a commit that referenced this pull request Jul 1, 2024
…che#4006)

### What changes were proposed in this pull request?

Frontend integration test failed in certain headless environment, like
the ec2 in aws.

### Why are the changes needed?

 Frontend integration test failed due to the following error:
```
 MetalakePageTest > initializationError FAILED
    org.openqa.selenium.WebDriverException: unknown error: Chrome failed to start: exited abnormally.
      (chrome not reachable)
      (The process started from chrome location /actions-runner/_work/gravitino-test/gravitino-test/gravitino/integration-test/build/chrome/chrome-linux/chrome is no longer running, so ChromeDriver is assuming that Chrome has crashed.)
    Build info: version: '3.141.59', revision: 'e82be7d358', time: '2018-11-14T08:17:03'
    System info: host: 'ip-172-31-5-251', ip: '172.31.5.251', os.name: 'Linux', os.arch: 'amd64', os.version: '6.5.0-1020-aws', java.version: '1.8.0_412'
    Driver info: driver.version: ChromeDriver
    remote stacktrace: #0 0x561b8bc79869 <unknown>
    #1 0x561b8bc14383 <unknown>
    #2 0x561b8b9f6ca3 <unknown>
    #3 0x561b8ba1a286 <unknown>
    #4 0x561b8ba157cd <unknown>
    #5 0x561b8ba4f11d <unknown>
    #6 0x561b8ba49963 <unknown>
    #7 0x561b8ba1fe36 <unknown>
    #8 0x561b8ba20fd5 <unknown>
    #9 0x561b8bc41f90 <unknown>
    #10 0x561b8bc53d80 <unknown>
```

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

<img width="1492" alt="image"
src="https://github.com/datastrato/gravitino/assets/154112360/3e16870e-ad51-4677-aec5-8e8be0c68f9b">
yuqi1129 pushed a commit that referenced this pull request Sep 5, 2024
…e#31)

### What changes were proposed in this pull request?

This PR proposes to add Jetty server support for Graviton.

### Why are the changes needed?

The purpose of introducing Jetty as embedded web server is that:

1. Jetty is a light-weighted web server that can be easily embedded into
our project compared to Tomcat and other services.
2. We basically don't want to introduce a bunch of Springboot related
code to build our REST API. In that case, Jersey + Jetty would be the
best choice.
3. If later on the performance of Jetty cannot meet our requirements, we
can shift to use other web servers instead.

Fix: #5

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

Local manual test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant