Skip to content

Commit

Permalink
Fix Checkstyle
Browse files Browse the repository at this point in the history
  • Loading branch information
yuxunn committed Oct 24, 2023
1 parent 041cd7a commit 01acabf
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ public void equals() {

// same values -> returns true
assertTrue(commandResult.equals(new CommandResult("feedback")));
assertTrue(commandResult.equals(new CommandResult("feedback", false, false)));
assertTrue(commandResult.equals(new CommandResult("feedback", false, false,"feedback")));

// same object -> returns true
assertTrue(commandResult.equals(commandResult));
Expand All @@ -29,10 +29,10 @@ public void equals() {
assertFalse(commandResult.equals(new CommandResult("different")));

// different showHelp value -> returns false
assertFalse(commandResult.equals(new CommandResult("feedback", true, false)));
assertFalse(commandResult.equals(new CommandResult("feedback", true, false, "help")));

// different exit value -> returns false
assertFalse(commandResult.equals(new CommandResult("feedback", false, true)));
assertFalse(commandResult.equals(new CommandResult("feedback", false, true, "exit")));
}

@Test
Expand All @@ -46,10 +46,10 @@ public void hashcode() {
assertNotEquals(commandResult.hashCode(), new CommandResult("different").hashCode());

// different showHelp value -> returns different hashcode
assertNotEquals(commandResult.hashCode(), new CommandResult("feedback", true, false).hashCode());
assertNotEquals(commandResult.hashCode(), new CommandResult("feedback", true, false, "help").hashCode());

// different exit value -> returns different hashcode
assertNotEquals(commandResult.hashCode(), new CommandResult("feedback", false, true).hashCode());
assertNotEquals(commandResult.hashCode(), new CommandResult("feedback", false, true, "exit").hashCode());
}

@Test
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ public class ExitCommandTest {

@Test
public void execute_exit_success() {
CommandResult expectedCommandResult = new CommandResult(MESSAGE_EXIT_ACKNOWLEDGEMENT, false, true);
CommandResult expectedCommandResult = new CommandResult(MESSAGE_EXIT_ACKNOWLEDGEMENT, false, true, "exit");
assertCommandSuccess(new ExitCommand(), model, expectedCommandResult, expectedModel);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ public class HelpCommandTest {

@Test
public void execute_help_success() {
CommandResult expectedCommandResult = new CommandResult(SHOWING_HELP_MESSAGE, true, false);
CommandResult expectedCommandResult = new CommandResult(SHOWING_HELP_MESSAGE, true, false, "help");
assertCommandSuccess(new HelpCommand(), model, expectedCommandResult, expectedModel);
}
}

0 comments on commit 01acabf

Please sign in to comment.