Add null check for key milestone

yuxunn · Nov 8, 2023 · 7663905 · 7663905
1 parent 86a6e91
commit 7663905
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/src/main/java/seedu/address/storage/JsonAdaptedPerson.java b/src/main/java/seedu/address/storage/JsonAdaptedPerson.java
@@ -141,11 +141,15 @@ public Person toModelType() throws IllegalValueException {
         final Set<Tag> modelTags = new HashSet<>(personTags);
 
         if (type == null) {
-            throw new IllegalValueException(String.format(MISSING_FIELD_MESSAGE_FORMAT, "Type"));
+            throw new IllegalValueException(String.format(MISSING_FIELD_MESSAGE_FORMAT, Type.class.getSimpleName()));
         }
         if (type.equals(TYPE_CLIENT)) {
             return new Client(modelName, modelPhone, modelEmail, modelAddress, modelMeetingTime, modelTags);
         } else if (type.equals(TYPE_LEAD)) {
+            if (keyMilestone == null) {
+                throw new IllegalValueException(String.format(MISSING_FIELD_MESSAGE_FORMAT,
+                        KeyMilestone.class.getSimpleName()));
+            }
             if (!KeyMilestone.isValidKeyMilestone(keyMilestone)) {
                 throw new IllegalValueException(KeyMilestone.MESSAGE_CONSTRAINTS);
             }