fixes: python -m build fails #14
Conversation
python -m build fails with: > running check > error: The docutils package is needed. since check.restructuredtext is set to 1 in setup.cfg, setuptools with require docutils. I think this is needed to parse the structured text README. That dependency needs to be specify in pyproject.toml file. It is recommended practice to have a pyproject.toml file anyway. https://packaging.python.org/en/latest/guides/modernize-setup-py-project/#should-pyproject-toml-be-added
|
@arenevier does it make sense to add a CI with this command |
Build a source distribution and a binary distribution when running tox. This makes sure we don't break those
|
@ggrossetie : good idea. Instead of adding a new CI step, I added two new targets to tox. One to build the source distribution (the one currently failing). And one to build binary distribution (which is not currently broken). |
|
Just to be sure, the two new targets do not run on the CI? If not, I think we should run them to make sure that a future pull request won't break them. |
|
Also, I just noticed that we don't have a tox environment for Pillow 10.x |
I can make a new PR to add it. And maybe python 3.12. I will wait for this one to be merged first, otherwise there will be merge conflicts. |
Fixed. They run now with the latest commit of the branch. |
|
Awesome, thanks 🎉 |
python -m build fails with:
since check.restructuredtext is set to 1 in setup.cfg, setuptools with require docutils. I think this is needed to parse the structured text README.
That dependency needs to be specify in pyproject.toml file. It is recommended practice to have a pyproject.toml file anyway. https://packaging.python.org/en/latest/guides/modernize-setup-py-project/#should-pyproject-toml-be-added